From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Apr 9 21:00:33 2012 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id CAEE81065674 for ; Mon, 9 Apr 2012 21:00:33 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 987E08FC20 for ; Mon, 9 Apr 2012 21:00:33 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q39L0X8q090018 for ; Mon, 9 Apr 2012 21:00:33 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q39L0XF3090017; Mon, 9 Apr 2012 21:00:33 GMT (envelope-from gnats) Resent-Date: Mon, 9 Apr 2012 21:00:33 GMT Resent-Message-Id: <201204092100.q39L0XF3090017@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Tijl Coosemans Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 15DFB1065674 for ; Mon, 9 Apr 2012 20:56:51 +0000 (UTC) (envelope-from tijl@coosemans.org) Received: from mailrelay012.isp.belgacom.be (mailrelay012.isp.belgacom.be [195.238.6.179]) by mx1.freebsd.org (Postfix) with ESMTP id 9875F8FC0A for ; Mon, 9 Apr 2012 20:56:50 +0000 (UTC) Received: from 211.90-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.90.211]) by relay.skynet.be with ESMTP; 09 Apr 2012 22:55:29 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.5/8.14.5) with ESMTP id q39KtSuv012063 for ; Mon, 9 Apr 2012 22:55:29 +0200 (CEST) (envelope-from tijl@kalimero.tijl.coosemans.org) Received: (from tijl@localhost) by kalimero.tijl.coosemans.org (8.14.5/8.14.5/Submit) id q39KtSDg012062; Mon, 9 Apr 2012 22:55:28 +0200 (CEST) (envelope-from tijl) Message-Id: <201204092055.q39KtSDg012062@kalimero.tijl.coosemans.org> Date: Mon, 9 Apr 2012 22:55:28 +0200 (CEST) From: Tijl Coosemans To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/166803: [patch] sysutils/xfce4-utils: fix running/killing of gpg-agent X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Tijl Coosemans List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2012 21:00:33 -0000 >Number: 166803 >Category: ports >Synopsis: [patch] sysutils/xfce4-utils: fix running/killing of gpg-agent >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Apr 09 21:00:32 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Tijl Coosemans >Release: FreeBSD 10.0-CURRENT i386 >Organization: >Environment: >Description: Xfce xinitrc script runs gpg-agent when it is installed (security/gnupg), but when the user uses csh as shell gpg-agent returns csh commands which of course cannot be executed from an sh script like xinitrc. The attached patch passes --sh to gpg-agent so it always returns sh commands. >How-To-Repeat: Install security/gnupg and run startxfce4. You'll see errors about setenv at startup and about kill at shutdown. >Fix: Patch to put in sysutils/xfce4-utils/files. --- patch-scripts-xinitrc.in.in begins here --- --- scripts/xinitrc.in.in.orig 2012-04-09 22:20:51.000000000 +0200 +++ scripts/xinitrc.in.in 2012-04-09 22:21:29.000000000 +0200 @@ -155,11 +155,11 @@ case "$ssh_agent_type" in gpg-agent) if test -z "$SSH_AGENT_PID"; then - eval `gpg-agent --daemon --enable-ssh-support --write-env-file $XDG_CACHE_HOME/gpg-agent-info` + eval `gpg-agent --sh --daemon --enable-ssh-support --write-env-file $XDG_CACHE_HOME/gpg-agent-info` ssh_agent_kill_cmd="kill -INT $SSH_AGENT_PID; rm -f $XDG_CACHE_HOME/gpg-agent-info" elif test -z "$GPG_AGENT_INFO"; then echo "ssh-agent is already running; starting gpg-agent without ssh support" - eval `gpg-agent --daemon --write-env-file $XDG_CACHE_HOME/gpg-agent-info` + eval `gpg-agent --sh --daemon --write-env-file $XDG_CACHE_HOME/gpg-agent-info` ssh_agent_kill_cmd="pkill -INT ^gpg-agent\$; rm -f $XDG_CACHE_HOME/gpg-agent-info" else echo "gpg-agent is already running" --- patch-scripts-xinitrc.in.in ends here --- >Release-Note: >Audit-Trail: >Unformatted: