From owner-cvs-src@FreeBSD.ORG Thu Mar 15 01:37:54 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DB3B916A41A for ; Thu, 15 Mar 2007 01:37:54 +0000 (UTC) (envelope-from nate@root.org) Received: from root.org (root.org [67.118.192.226]) by mx1.freebsd.org (Postfix) with ESMTP id AB55013C46A for ; Thu, 15 Mar 2007 01:37:54 +0000 (UTC) (envelope-from nate@root.org) Received: (qmail 97391 invoked from network); 15 Mar 2007 01:37:21 -0000 Received: from ppp-71-139-18-69.dsl.snfc21.pacbell.net (HELO ?10.0.0.235?) (nate-mail@71.139.18.69) by root.org with ESMTPA; 15 Mar 2007 01:37:21 -0000 Message-ID: <45F8A347.2080708@root.org> Date: Wed, 14 Mar 2007 18:37:11 -0700 From: Nate Lawson User-Agent: Thunderbird 1.5.0.7 (X11/20061027) MIME-Version: 1.0 To: Julian Elischer References: <20070314223016.7CD4E16A418@hub.freebsd.org> <45F8793E.5080602@elischer.org> <45F8804F.1050606@root.org> <45F88B54.7070305@elischer.org> In-Reply-To: <45F88B54.7070305@elischer.org> X-Enigmail-Version: 0.94.1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, Alan Cox , cvs-all@freebsd.org Subject: Re: [SRC] cvs commit: src/sys/i386/acpica acpi_wakeup.c src/sys/i386/i386 pmap.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2007 01:37:54 -0000 Julian Elischer wrote: > Nate Lawson wrote: >>>> Index: src/sys/i386/i386/pmap.c >>>> diff -u src/sys/i386/i386/pmap.c:1.582 src/sys/i386/i386/pmap.c:1.583 >>>> --- src/sys/i386/i386/pmap.c:1.582 Mon Mar 5 21:40:10 2007 >>>> +++ src/sys/i386/i386/pmap.c Wed Mar 14 22:30:02 2007 >>>> @@ -422,6 +422,13 @@ >>>> >>>> /* Turn on PG_G on kernel page(s) */ >>>> pmap_set_pg(); >>>> + >>>> + /* >>>> + * Create an identity mapping (virt == phys) for the low 1 MB >>>> + * physical memory region that is used by the ACPI wakeup code. >>>> + * This mapping must not have PG_G set. + */ >>>> + kernel_pmap->pm_pdir[0] = PG_PS | PG_RW | PG_V; >>>> } >>>> >>>> /* >> >> I propose conditionalizing this code on "if (pseflag)". Of course, the >> acpi suspend code will fail on 486's but we disable acpi entirely if the >> bios date < 1999/1/1 and acpi isn't supported on the 486. > > as long as you are keeping this in mind, I have no objection as to how > you tackle it.. > > so if someone uses a 486 based embedded system (low power etc.) > they can definitely not have any acpi support in the bios? I will wait and see what others say. In general, I'm sure there are other aspects of ACPI that require a Pentium. And remember, they could still boot acpi with a 486 and use everything but suspend/resume. -- Nate