From owner-cvs-ports@FreeBSD.ORG  Wed Mar 19 08:24:49 2008
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
	id 694CC1065670; Wed, 19 Mar 2008 08:24:49 +0000 (UTC)
Date: Wed, 19 Mar 2008 08:24:49 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Beech Rintoul <beech@freebsd.org>
Message-ID: <20080319082449.GA47448@FreeBSD.org>
References: <200803190656.m2J6u5bJ070157@repoman.freebsd.org>
	<20080319073221.GA36479@FreeBSD.org>
	<200803182350.49514.beech@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <200803182350.49514.beech@freebsd.org>
User-Agent: Mutt/1.4.2.1i
Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject: Re: cvs commit: ports/games/blockade Makefile
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
	<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Mar 2008 08:24:49 -0000

On Tue, Mar 18, 2008 at 11:50:44PM -0800, Beech Rintoul wrote:
> On Tuesday 18 March 2008, Alexey Dokuchaev said:
> > On Wed, Mar 19, 2008 at 06:56:05AM +0000, Beech Rintoul wrote:
> > > beech       2008-03-19 06:56:05 UTC
> > >
> > >   FreeBSD ports repository
> > >
> > >   Modified files:
> > >     games/blockade       Makefile
> > >   Log:
> > >   - Remove USE_X_PREFIX
> > >   - Bump portrevision
> >
> > Apparently the log message does not describe what exactly was
> > changed: s/USE_XLIB/USE_XORG/ is not the same as removing of
> > USE_X_PREFIX.
> 
> I would suggest that since you seem to have the free time to review 
> commits that you use it constructively to contribute to the effort:
> 
> http://wiki.freebsd.org/Ports/X11/Todo

I'm not sure why, but do you sound a bit offended?  I didn't mean to
pick on you.  I'm not reviewing every commit, either yours or someone's
else.  I just thought that combination of dropping USE_X_PREFIX and
PORTREVISION bump is kinda weird, and decided to take a look.

As a side note, for many years peer review in this project was commonly
appreciated by its members.  Yet I'm starting to see occasional
complaints like yours from time to time.  I'm not sure why; did we stop
caring for quality of what we commit?  You can always review mine, I'd
just be grateful.

./danfe

P.S.  I'm still awaiting answers for couple of my emails, BTW.  :-)