From owner-svn-src-head@FreeBSD.ORG Fri Apr 27 18:12:26 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 285861065677; Fri, 27 Apr 2012 18:12:26 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 238D98FC24; Fri, 27 Apr 2012 18:12:24 +0000 (UTC) Received: by bkcjc3 with SMTP id jc3so961027bkc.13 for ; Fri, 27 Apr 2012 11:12:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=1cJEQFwn2p2Wcaszi1hxe01tdO82hrOvwNGOSf8sSnc=; b=XYi+gzsDlvLRS2T43MRc5AaWy6Sb46wLx5IbIVxDIrAnB2MAAhCghhqqZXxBR+KbY3 NS7GeZzbhPj3sQPc6gBib3LiEU0sPAzZcGH8XNeYqgH5aj8dN2ekA9YwX3mM5WywJ3tT b2L/Vkttgye5Bu+fmOQHiYC4qOUq7xWOXjRZdicyxkKW0k2lDFyFFbnCCltCTOF8eqXV h+9dL7jqdJpWS2oiEstK4ulAl9UWdqBAc10BaUahB1SPhr3uRGfEs7HgqeYjfBzNdWAU nn6gUavHff0+mYQ+vNPpwq+jsmzZt1hge5xPA3g6Iz/ZEDqmnVEjTVUxLVX0wkZJJXnC 0VdQ== Received: by 10.204.9.195 with SMTP id m3mr4435810bkm.78.1335550344220; Fri, 27 Apr 2012 11:12:24 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua. [212.86.226.226]) by mx.google.com with ESMTPS id n17sm6129525bkw.5.2012.04.27.11.12.20 (version=SSLv3 cipher=OTHER); Fri, 27 Apr 2012 11:12:22 -0700 (PDT) Sender: Alexander Motin Message-ID: <4F9AE183.7060209@FreeBSD.org> Date: Fri, 27 Apr 2012 21:12:19 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:10.0.3) Gecko/20120328 Thunderbird/10.0.3 MIME-Version: 1.0 To: John Baldwin References: <201204231304.q3ND43Yg098748@svn.freebsd.org> <201204270745.16844.jhb@freebsd.org> <1335547643.283.YahooMailNeo@web45713.mail.sp1.yahoo.com> <201204271338.37236.jhb@freebsd.org> In-Reply-To: <201204271338.37236.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , Scott Long Subject: Re: svn commit: r234603 - head/sys/geom/raid X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2012 18:12:26 -0000 On 04/27/12 20:38, John Baldwin wrote: > On Friday, April 27, 2012 1:27:23 pm Scott Long wrote: >> >> ----- Original Message ----- >>> From: John Baldwin >>> To: Alexander Motin >>> Cc: src-committers@freebsd.org; svn-src-all@freebsd.org; svn-src-head@freebsd.org >>> Sent: Friday, April 27, 2012 5:45 AM >>> Subject: Re: svn commit: r234603 - head/sys/geom/raid >>> >>> On Monday, April 23, 2012 9:04:03 am Alexander Motin wrote: >>>> Author: mav >>>> Date: Mon Apr 23 13:04:02 2012 >>>> New Revision: 234603 >>>> URL: http://svn.freebsd.org/changeset/base/234603 >>>> >>>> Log: >>>> Add names for all primary RAID levels defined by DDF 2.0 specification. >>>> >>>> Modified: >>>> head/sys/geom/raid/g_raid.c >>>> head/sys/geom/raid/g_raid.h >>>> head/sys/geom/raid/tr_raid1.c >>>> head/sys/geom/raid/tr_raid1e.c >>> >>> We should probably add a separate header to hold DDF constants. graid isn't >>> the only place that uses them (e.g. mfi(4) uses it to describe volumes, so >>> mfiutil(8) has its own DDF constants as well in mfiutil.h). >>> >>> -- >> >> You mean src/sys/dev/ata/ata-raid-ddf.h? > > Yes. > >> That said, I trust DDF to be neither universal nor standard, and it's probably a futile micro-optimization to try too hard at this. At the very > least, leave MFI alone. Standard or not, DDF is the only public specification and it is quite universal from point of reviewing possible configurations. That's why I took it as reference instead of reinventing own numbers. Same time metadata modules in graid may do own translation and theoretically support some other configurations, that's why I am not exactly comfortable with idea of merging these lists and strictly tying to DDF. > Hmm, LSI claims that MFI uses the constant values (but not necessarily the > structures from DDF). Certainly the primary RAID type in an mfi(4) volume > uses the same constants as both g_raid.h and ata-raid-ddf.h. ata-raid-ddf.h as all ataraid(4) is not actively used now and should leave. Instead I am now writing DDF module for graid and going to resurrect that file there with minor updates. These two files could be merged, but I am not sure it worth to be done either, as it is temporary coexistence. -- Alexander Motin