From owner-freebsd-current@FreeBSD.ORG Thu Sep 16 12:38:08 2010 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 62E06106570A for ; Thu, 16 Sep 2010 12:38:08 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id 302878FC08 for ; Thu, 16 Sep 2010 12:38:08 +0000 (UTC) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id C83EC46B5C; Thu, 16 Sep 2010 08:38:07 -0400 (EDT) Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 4D20D8A050; Thu, 16 Sep 2010 08:38:06 -0400 (EDT) From: John Baldwin To: freebsd-current@freebsd.org Date: Thu, 16 Sep 2010 08:27:30 -0400 User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; ) References: <201009151749.45038.jhb@freebsd.org> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <201009160827.30410.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Thu, 16 Sep 2010 08:38:06 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: Marcin Cieslak Subject: Re: tun(4) in -CURRENT: No buffer space available - race condition patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Sep 2010 12:38:08 -0000 On Wednesday, September 15, 2010 5:57:34 pm Marcin Cieslak wrote: > Dnia 15.09.2010 John Baldwin napisa=C5=82/a: > > On Monday, September 13, 2010 9:10:01 pm Marcin Cieslak wrote: > >> Output queue of tun(4) gets full after some time when sending lots of = data. > >> I have been observing this on -CURRENT at least since March this year. > >>=20 > >> Looks like it's a race condition (same in tun(4) and tap(4)),=20 > >> the following patch seems to address the issue: > > > > This is a good find. I actually went through these drivers a bit furth= er and=20 > > have a bit of a larger patch to extend the locking some. Would you car= e to=20 > > test it? >=20 > Sure, I am installing it right now (for if_tun right now). >=20 > There are also a LORs during tunclose (I always get one of them when clos= ing the > tunnel): Hmm, this looks to be in the if_purgeaddrs() routine itself and not specific to tun/tap. =2D-=20 John Baldwin