From nobody Mon Aug 18 13:57:25 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c5Dmj59ylz63jl1; Mon, 18 Aug 2025 13:57:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c5Dmj4bdnz42gM; Mon, 18 Aug 2025 13:57:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755525445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k7XlwVyldoxDezrxyqu2Usp346zyratI5haYtUDwV5A=; b=Nhyrh4gOOeX7RsqOX0oEcClAcHxx0gwbvtFQkHt0zzNfnVhBEYydh/dSErTphIwoHTRIq9 qJHtcBo6iAl07seft1oHk9npyxmpUhK9o6oypEC9CVXYtkcPva3INj4Bt4pfkb53IYSmPW 6PJjNmHWL+RnK0gvPyoPQjbaxy60toKyanWpfTFrV/g9fsQd7B3YSNFqO22CpYwoS7GyVV 92PNeRvnZkDXkodK1unzJgD5Rz6nJZeoVn92JmW251psx2A5RklmLxFo5QXpRszzuiOmoo XmCscogsnNuhzChCUAH0OxtdzACr8xuJrhdJweUUpe1dKBpys05L6vlWHY9JFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1755525445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=k7XlwVyldoxDezrxyqu2Usp346zyratI5haYtUDwV5A=; b=D8jMupM4EQ7g6Qve6t+lsu3lphYNEEtnlMa1+MYkjxdT7rxehUHMSmrhu1gZ37qgS+3XEa lM9vS5x2+M83sdlW2q703L4PVTEap6GfhPCzIBRBBUEL+cWgIWBXeZ8Nm0W4kus2UXooCK iUspjEo6RrkeG0Wgu1vwST+C0WdXvF211A5SdKM+rmNF0TbHAXXW1tbO5JM4N08jvF3bmh fOpqrzWvuIROcXdftt5ZG1bwzIoovQpe+DVs3GKhz9j/fS/8Np2vefEqt7NzDGpfR/GLmp YxFYHFxPCCPqGZ2jwDhcISIjMaIs+obavWlIcg1sQWdx97h7HMrh54P2gLmwNA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1755525445; a=rsa-sha256; cv=none; b=nHWfWQhj9XOvBRS3APffkQkgUacucwpjRJUI3mR3KVeBjOXdUzcwZKhP/9OIO7K7IN+llO umA2Z/GiqZCq4gfKO8DnVDdAk4AMTmNbZ/7Hv953glaI24uI2EwOc44grZyUmlOeedn9Mb qYuo7hhp382gd6jxF69WMGC8Pi9T3m62a6vBxPZ33OS2ZaBxYb72SMfV92cvNks7bDimv5 Viyonl/hbPQphubSMce7nCphM+NHdeGPVsZp8JR7Im5eOwIA0eId5t4iJJQpTqOn9sw9YW JNQfslKE7POJAWpkTTUq4SWZtcU7uXWVPOJ2BiTGy/RxJAr/Ilzu0N1lc2K0WA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4c5Dmj48grz10SW; Mon, 18 Aug 2025 13:57:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 57IDvPKn089995; Mon, 18 Aug 2025 13:57:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 57IDvP9Y089992; Mon, 18 Aug 2025 13:57:25 GMT (envelope-from git) Date: Mon, 18 Aug 2025 13:57:25 GMT Message-Id: <202508181357.57IDvP9Y089992@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Aymeric Wibo Subject: git: 39dbadb7a410 - main - netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: obiwac X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 39dbadb7a410f3955540041848d669264266e552 Auto-Submitted: auto-generated The branch main has been updated by obiwac: URL: https://cgit.FreeBSD.org/src/commit/?id=39dbadb7a410f3955540041848d669264266e552 commit 39dbadb7a410f3955540041848d669264266e552 Author: Muhammad Saheed AuthorDate: 2025-08-18 13:50:08 +0000 Commit: Aymeric Wibo CommitDate: 2025-08-18 13:51:10 +0000 netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler IFF_UP could previously only be unset via RTM_NEWLINK. Requests to set IFF_UP, though they succeed, did not actually set the flag. RTM_NEWLINK messages with ifi_change=0 are treated as ifi_change=0xFFFFFFFF, modifying all the link flags (currently IFF_UP and IFF_PROMISC) to match the behavior seen on Linux. Reviewed by: obiwac, kp, mckusick (mentor) Approved by: obiwac, mckusick (mentor) Sponsored by: Google LLC (GSoC) Differential Revision: https://reviews.freebsd.org/D51871 --- sys/netlink/route/iface_drivers.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sys/netlink/route/iface_drivers.c b/sys/netlink/route/iface_drivers.c index 4bf913d9c978..5f605b05f7b8 100644 --- a/sys/netlink/route/iface_drivers.c +++ b/sys/netlink/route/iface_drivers.c @@ -82,9 +82,12 @@ _nl_modify_ifp_generic(struct ifnet *ifp, struct nl_parsed_link *lattrs, } } - if ((lattrs->ifi_change & IFF_UP) && (lattrs->ifi_flags & IFF_UP) == 0) { - /* Request to down the interface */ - if_down(ifp); + if ((lattrs->ifi_change & IFF_UP) != 0 || lattrs->ifi_change == 0) { + /* Request to up or down the interface */ + if (lattrs->ifi_flags & IFF_UP) + if_up(ifp); + else + if_down(ifp); } if (lattrs->ifla_mtu > 0) { @@ -97,7 +100,8 @@ _nl_modify_ifp_generic(struct ifnet *ifp, struct nl_parsed_link *lattrs, } } - if (lattrs->ifi_change & IFF_PROMISC) { + if ((lattrs->ifi_change & IFF_PROMISC) != 0 || + lattrs->ifi_change == 0) { error = ifpromisc(ifp, lattrs->ifi_flags & IFF_PROMISC); if (error != 0) { nlmsg_report_err_msg(npt, "unable to set promisc");