From nobody Wed Apr 13 00:57:21 2022 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CC2F111CC8D1; Wed, 13 Apr 2022 00:57:24 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4KdPM85TCFz4X3f; Wed, 13 Apr 2022 00:57:24 +0000 (UTC) (envelope-from rpokala@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649811444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S9ZtQrAg4clHYGzglRi4COWKNwexCPF9MyFBRIovp/s=; b=utZGqpH8NWdLnXaLfFSjhyAJMKxUm6C8qpfZcG8Y8x1T9122LzV7ImxUvF6NVqdpXstP4x k6Fgqrmjvo9R2JQUKvU68urldG0Xwbo0mi8r7Uw7s5HWo5+vMlDJjWkCOe2ysZiqdKyseZ jv2vYTk+V21YRPMtJjJ80i5I0KDSKFIkOP8nERpsZyvQi2OZzJilcEq0af5xFB6dAW+hDn gLXXPGTB6UfT3WwSvcUbAcyh+w4jLKqp1FlwSd+KXJmLL+5GXC84NOHkdk77jGcBzdPQ+4 XYyQWa3T7oF7OamRWCWd370jY+4SeYFOPdcWgajlKy9ZFXL6/8NTLRfT1DvWTg== Received: from [172.17.133.71] (unknown [207.141.91.187]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 29D0025241; Wed, 13 Apr 2022 00:57:24 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.59.22031300 Date: Tue, 12 Apr 2022 17:57:21 -0700 Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around From: Ravi Pokala To: Kyle Evans , , , Message-ID: <0B5546D3-3623-4348-9AAF-A0AC0E3ACBFC@panasas.com> Thread-Topic: 454630c72556 - main - stand: libefi: swap /Pci() printing around References: <202204130034.23D0YCPN051666@gitrepo.freebsd.org> In-Reply-To: <202204130034.23D0YCPN051666@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1649811444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S9ZtQrAg4clHYGzglRi4COWKNwexCPF9MyFBRIovp/s=; b=hleV5+wC3BkWXjNqKUB0P6q99aOnSOaY8UJK6QPGakuMu4Ga34JB6IzzlAiCbQtLOIpe5c E+LyDDksFs1xegcr2sMN1CwmEoLUZZ4TjoQKusaS3EiNfIlA7xL/d2Y05HTJFMLRpmdYvW nsj0cPfCzTU70teFc5/QuPCepBm2sdl3SLmQCoaEj1Xl+kwwUQ7MOY4OnRxCpI18OAPWVA aBuLxd4Si8vveM0nqnMSJ7b36PMBclX9kGRZ2VwKsO0YPf43eAqmNBHz3XEjoY0c9ZJBfv BMJwJMEmAIg9UjLfwl1Gqn83m/CndX5SQ4Mn/BgMmN9uO40Ir141Sun6Et21tg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1649811444; a=rsa-sha256; cv=none; b=E+GeoJpzLg/ToTgCKkMe/eojt8ob5AH1I7dTr+KU9waz8aoHjv92RB6TAtE50qtpLOoUE+ 1yVVds5jQNNtIjCSDoTgUKy8nm+yHKCRalo6XF/9cooweskeoT26vnA8sHGiE6+rLQehrJ HErb/p20xCAyrOnT16zRqbriFVRslMvHfY29WYI4W+rJbWi38MDoThyxVqfJK3wOURftV8 CRoK94EEGlOyufWUBDeqHHXW9rfio5Nwi+V2F7ypUHNFCCT3gO0aEoxyKqQSmns9dgerCf wNaTGHtqZKcoc2c94P1rkPaaW98Ye1Lj0N3mtLHHISTuzpFxbr/BKNfgmr3qOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N -----Original Message----- From: on behalf of Kyle Evans Date: 2022-04-12, Tuesday at 17:34 To: , , Subject: git: 454630c72556 - main - stand: libefi: swap /Pci() printing around The branch main has been updated by kevans: URL: https://cgit.FreeBSD.org/src/commit/?id=454630c72556d45e401f29f56b3317c2fb0499a0 commit 454630c72556d45e401f29f56b3317c2fb0499a0 Author: Kyle Evans AuthorDate: 2022-04-13 00:29:54 +0000 Commit: Kyle Evans CommitDate: 2022-04-13 00:30:30 +0000 stand: libefi: swap /Pci() printing around Printing device followed by interface matches, e.g., edk2. Note that this is only a fallback, many firmware implementations will provide the protocol that we'll use to format device paths. "(device,function)" makes more sense anyway, since that's the logical organization (i.e. each unique device may have multiple functions). What was the rationale for doing "(function,device)" in the first place? -Ravi (rpokala@) Reviewed by: imp, tsoome Sponsored by: Ampere Computing Submitted by: Klara, Inc. Differential Revision: https://reviews.freebsd.org/D34539 --- stand/efi/libefi/devpath.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/stand/efi/libefi/devpath.c b/stand/efi/libefi/devpath.c index b56c583b5fa7..c25ae73e463c 100644 --- a/stand/efi/libefi/devpath.c +++ b/stand/efi/libefi/devpath.c @@ -146,8 +146,8 @@ efi_hw_dev_path(EFI_DEVICE_PATH *node, char *suffix) switch (subtype) { case HW_PCI_DP: if (asprintf(&name, "Pci(%x,%x)%s", - ((PCI_DEVICE_PATH *)node)->Function, - ((PCI_DEVICE_PATH *)node)->Device, tail) < 0) + ((PCI_DEVICE_PATH *)node)->Device, + ((PCI_DEVICE_PATH *)node)->Function, tail) < 0) name = NULL; break; case HW_PCCARD_DP: