Date: Tue, 12 Apr 2022 17:57:21 -0700 From: Ravi Pokala <rpokala@freebsd.org> To: Kyle Evans <kevans@FreeBSD.org>, <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org> Subject: Re: 454630c72556 - main - stand: libefi: swap /Pci() printing around Message-ID: <0B5546D3-3623-4348-9AAF-A0AC0E3ACBFC@panasas.com> In-Reply-To: <202204130034.23D0YCPN051666@gitrepo.freebsd.org> References: <202204130034.23D0YCPN051666@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----Original Message-----
From: <owner-src-committers@freebsd.org> on behalf of Kyle Evans <kevans@FreeBSD.org>
Date: 2022-04-12, Tuesday at 17:34
To: <src-committers@FreeBSD.org>, <dev-commits-src-all@FreeBSD.org>, <dev-commits-src-main@FreeBSD.org>
Subject: git: 454630c72556 - main - stand: libefi: swap /Pci() printing around
The branch main has been updated by kevans:
URL: https://cgit.FreeBSD.org/src/commit/?id=454630c72556d45e401f29f56b3317c2fb0499a0
commit 454630c72556d45e401f29f56b3317c2fb0499a0
Author: Kyle Evans <kevans@FreeBSD.org>
AuthorDate: 2022-04-13 00:29:54 +0000
Commit: Kyle Evans <kevans@FreeBSD.org>
CommitDate: 2022-04-13 00:30:30 +0000
stand: libefi: swap /Pci() printing around
Printing device followed by interface matches, e.g., edk2. Note that
this is only a fallback, many firmware implementations will provide the
protocol that we'll use to format device paths.
"(device,function)" makes more sense anyway, since that's the logical organization (i.e. each unique device may have multiple functions).
What was the rationale for doing "(function,device)" in the first place?
-Ravi (rpokala@)
Reviewed by: imp, tsoome
Sponsored by: Ampere Computing
Submitted by: Klara, Inc.
Differential Revision: https://reviews.freebsd.org/D34539
---
stand/efi/libefi/devpath.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/stand/efi/libefi/devpath.c b/stand/efi/libefi/devpath.c
index b56c583b5fa7..c25ae73e463c 100644
--- a/stand/efi/libefi/devpath.c
+++ b/stand/efi/libefi/devpath.c
@@ -146,8 +146,8 @@ efi_hw_dev_path(EFI_DEVICE_PATH *node, char *suffix)
switch (subtype) {
case HW_PCI_DP:
if (asprintf(&name, "Pci(%x,%x)%s",
- ((PCI_DEVICE_PATH *)node)->Function,
- ((PCI_DEVICE_PATH *)node)->Device, tail) < 0)
+ ((PCI_DEVICE_PATH *)node)->Device,
+ ((PCI_DEVICE_PATH *)node)->Function, tail) < 0)
name = NULL;
break;
case HW_PCCARD_DP:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?0B5546D3-3623-4348-9AAF-A0AC0E3ACBFC>