From nobody Mon Sep 25 11:00:53 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RvKft1zdGz4vNRp; Mon, 25 Sep 2023 11:00:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RvKft1KPqz3M6D; Mon, 25 Sep 2023 11:00:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695639654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vVnvt7C4VtjCZ8byiizKdUOuyCPxGdNNwV7fHoFCVnc=; b=edpCBtkkA0ZU6MYOA71fz4+mmKao5+94Y1c/OB/RIZKQiTeyEaWm4iWPe8BvDzDw5Frfd4 fM10K02DRkqON+Hf/Fg++s1q081BMJNIH/i/UlziJL8bnec47h20BrwpxXWjbXB0mlgWVo pNc7wkFu3txJzqTukpTpBTlJOHFWl7AxXrcPOovv9UY/4MsFAlTjI8fwMbv2JQwoKLCmPM Keb8gfrEusTMoasQau123P86JE7eI3WESi2KAwpX96ISoYk2NVOIM/yDwfU/FE2b94BXq6 MpQ3RqmDCDeDgX8z9OXVN1NnZ2a8OUnURG1Q3zt3mxBZhRbm1Kpz7dmuG+ppiA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1695639654; a=rsa-sha256; cv=none; b=Fnx7of2pvBI7mTHDQjtk7SDZ0EH3QVDXsHhlCp7ghajuNNzTnXEBlim4Uv81GjwS3AKxdv tb7M1mOoSK6yqxaLJQIWLr5qOH8mdySPEKzvNMnIWVkN76UfH+dgJkgTck8J9ogzG9WhjI ZRdby98tKND/puURvHWnBTEx47S5wFXx3HlKkR3qMl+Clh+arYvjkikgMuW4V9FUElVSlI Xq8uP1cMk8eBM8JistXHRcuD1O8bvVu8H2yvyNpUjPQTI1crTm3WZ0YawNObyi4/AtQ5e4 TKzkeTnFUJpEsX+f5/fmX8bzKaR6jcav37IKuEdXmzUmGAw8CxxgJBhxkxwfCw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1695639654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vVnvt7C4VtjCZ8byiizKdUOuyCPxGdNNwV7fHoFCVnc=; b=wStpz9s5nsip/cqmrmuo6PwEp/tyem6t/lQzV9I6kUJWqzAdk3oh04LdKyCke7aSw0qwza 7/0KRGOQKUgJ1YSffRAMmLAyMgaOqU0rs25g/bOrhyhdW3sbISYlL5pGCjmFodM8+ub8Cz 3XBpvl+kM3ZqcNYcDwviuUfwZR5jBo6P4hdoSQiOxpoO1x4jBgEx3549WrrdsE7togxqRD gUj9ssob/FjPyvHgOjJBPVNfUIQU/qSnlc3jRXq6/U5V9isk9sc6zzuITkcrRurgII9GXU uAX1fvVJ1oysslyZYvTxnTNlVjHJkBEpzltvGAXovsFnJtKzuNTZIjsIs8fTsw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RvKft0NCXz1QMk; Mon, 25 Sep 2023 11:00:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 38PB0r0o052776; Mon, 25 Sep 2023 11:00:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 38PB0r5q052773; Mon, 25 Sep 2023 11:00:53 GMT (envelope-from git) Date: Mon, 25 Sep 2023 11:00:53 GMT Message-Id: <202309251100.38PB0r5q052773@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Andrew Turner Subject: git: 57a615a47da4 - stable/13 - arm64: Print the spinlock count on panic List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 57a615a47da4b71ec4cacdbae23802e53c248844 Auto-Submitted: auto-generated The branch stable/13 has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=57a615a47da4b71ec4cacdbae23802e53c248844 commit 57a615a47da4b71ec4cacdbae23802e53c248844 Author: Andrew Turner AuthorDate: 2023-05-24 14:40:30 +0000 Commit: Andrew Turner CommitDate: 2023-09-25 08:41:16 +0000 arm64: Print the spinlock count on panic When the spinlock count is non-zero while taking a data abort we panic. Print this count to help debugging. Sponsored by: Arm Ltd (cherry picked from commit fa512fcd8fe74d72b7f29a324c8cd3ca20ff25c8) --- sys/arm64/arm64/trap.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/arm64/arm64/trap.c b/sys/arm64/arm64/trap.c index 45a4075507c3..7906bd94d470 100644 --- a/sys/arm64/arm64/trap.c +++ b/sys/arm64/arm64/trap.c @@ -304,7 +304,8 @@ data_abort(struct thread *td, struct trapframe *frame, uint64_t esr, print_registers(frame); print_gp_register("far", far); printf(" esr: %.16lx\n", esr); - panic("data abort with spinlock held"); + panic("data abort with spinlock held (spinlock count %d != 0)", + td->td_md.md_spinlock_count); } #endif if (td->td_critnest != 0 || WITNESS_CHECK(WARN_SLEEPOK |