Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Sep 2023 11:00:53 GMT
From:      Andrew Turner <andrew@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: 57a615a47da4 - stable/13 - arm64: Print the spinlock count on panic
Message-ID:  <202309251100.38PB0r5q052773@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/13 has been updated by andrew:

URL: https://cgit.FreeBSD.org/src/commit/?id=57a615a47da4b71ec4cacdbae23802e53c248844

commit 57a615a47da4b71ec4cacdbae23802e53c248844
Author:     Andrew Turner <andrew@FreeBSD.org>
AuthorDate: 2023-05-24 14:40:30 +0000
Commit:     Andrew Turner <andrew@FreeBSD.org>
CommitDate: 2023-09-25 08:41:16 +0000

    arm64: Print the spinlock count on panic
    
    When the spinlock count is non-zero while taking a data abort we panic.
    Print this count to help debugging.
    
    Sponsored by:   Arm Ltd
    
    (cherry picked from commit fa512fcd8fe74d72b7f29a324c8cd3ca20ff25c8)
---
 sys/arm64/arm64/trap.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/arm64/arm64/trap.c b/sys/arm64/arm64/trap.c
index 45a4075507c3..7906bd94d470 100644
--- a/sys/arm64/arm64/trap.c
+++ b/sys/arm64/arm64/trap.c
@@ -304,7 +304,8 @@ data_abort(struct thread *td, struct trapframe *frame, uint64_t esr,
 		print_registers(frame);
 		print_gp_register("far", far);
 		printf(" esr: %.16lx\n", esr);
-		panic("data abort with spinlock held");
+		panic("data abort with spinlock held (spinlock count %d != 0)",
+		    td->td_md.md_spinlock_count);
 	}
 #endif
 	if (td->td_critnest != 0 || WITNESS_CHECK(WARN_SLEEPOK |



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202309251100.38PB0r5q052773>