From owner-freebsd-ports Thu Aug 20 16:14:01 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id QAA16472 for freebsd-ports-outgoing; Thu, 20 Aug 1998 16:14:01 -0700 (PDT) (envelope-from owner-freebsd-ports@FreeBSD.ORG) Received: from hwcn.org (james.hwcn.org [199.212.94.66]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id QAA16459; Thu, 20 Aug 1998 16:13:56 -0700 (PDT) (envelope-from hoek@hwcn.org) Received: from localhost (ac199@localhost) by hwcn.org (8.8.8/8.8.8) with SMTP id TAA22489; Thu, 20 Aug 1998 19:10:57 -0400 (EDT) Date: Thu, 20 Aug 1998 19:10:56 -0400 (EDT) From: Tim Vanderhoek To: Satoshi Asami cc: obrien@NUXI.com, ports@FreeBSD.ORG, hoek@FreeBSD.ORG Subject: Re: cvs commit: ports/lang/glibstdc++28 Makefile In-Reply-To: <199808192353.QAA03197@silvia.hip.berkeley.edu> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Wed, 19 Aug 1998, Satoshi Asami wrote: > +.if !target(generate-plist) > +generate-plist: > + @if [ ! -f ${PLIST} -o ! -f ${COMMENT} -o ! -f ${DESCR} ]; then ${ECHO} "** Missing package files for ${PKGNAME}."; exit 1; fi I'm not sure this is quite right. For example, the ilu port creates its whole PLIST in the post-install target. To make the port work with the current bsd.port.mk, I added TMPPLIST= ${PLIST} Which won't work with the new change. I think just keeping the test in fake-pkg: is enough, although I do have patches that change "generate-plist:" to "${TMPPLIST}:" and make fake-pkg depend on "${TMPPLIST}". This is kinda cool and also should solve the problem (although writing generate-plist target that forces plist generation iff TMPPLIST and PLIST refer to different files was tricky). Other than that, only a little (but unfortunately lengthy) comment on your original message with patches... :) [From a now dead message :] > One thing we can easily add is to substitute stuff in DESCR. Things > like PREFIX come to mind. I'm not sure if it's worth the complication > though. I'm not sure this is a good idea... That would make, eg. http://www.FreeBSD.ORG/ports have problems. The general idea is worthwhile. For example, it would be nice if the apache+php+msql+foobaz+legal.zip binary package could include a description of itself saying "This package is for the `legal' papersize.". However, I don't think we're quite at the point where we need to cross that bridge, yet. :-) It probably would be useful to do the substitions on pkg/MESSAGE. It would be necessary to run pkg/MESSAGE through fmt(1) afterwards (with an option to disable this). Of course, a port wanting substitutions can do it fairly easily with ${SED} ${_sedsubplist} file themselves. Useful for ports submitted by pedants who feel obligated to fix ${PREFIX} in the manpages. :) Letting the port makefile do this itself allows it to ensure it's done before the manpages are installed. -- Outnumbered? Maybe. Outspoken? Never! tIM...HOEk To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message