From owner-dev-commits-src-main@freebsd.org Wed Jan 27 00:00:57 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 86F124E5256; Wed, 27 Jan 2021 00:00:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4DQNzY2D8Sz4fvb; Wed, 27 Jan 2021 00:00:57 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 10R00nEw041641 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Wed, 27 Jan 2021 02:00:52 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 10R00nEw041641 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 10R00nP0041636; Wed, 27 Jan 2021 02:00:49 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 27 Jan 2021 02:00:49 +0200 From: Konstantin Belousov To: Brooks Davis Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d89c1c461ce3 - main - Reserve gaps in syscall numbers for local use Message-ID: References: <202101261828.10QISOKh066392@gitrepo.freebsd.org> <20210126233417.GA6607@spindle.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210126233417.GA6607@spindle.one-eyed-alien.net> X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4DQNzY2D8Sz4fvb X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Jan 2021 00:00:57 -0000 On Tue, Jan 26, 2021 at 11:34:17PM +0000, Brooks Davis wrote: > On Wed, Jan 27, 2021 at 12:50:35AM +0200, Konstantin Belousov wrote: > > On Tue, Jan 26, 2021 at 06:28:24PM +0000, Brooks Davis wrote: > > > The branch main has been updated by brooks: > > > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=d89c1c461ce31bfc789dbb7bc5f4fce5824c595e > > > > > > commit d89c1c461ce31bfc789dbb7bc5f4fce5824c595e > > > Author: Brooks Davis > > > AuthorDate: 2021-01-26 18:27:45 +0000 > > > Commit: Brooks Davis > > > CommitDate: 2021-01-26 18:27:45 +0000 > > > > > > Reserve gaps in syscall numbers for local use > > > > > > It is best for auditing of syscalls.master if we only append to the > > > file. Reserving unimplemented system call numbers for local use makes > > > this policy and provides a large set of syscall numbers FreeBSD > > > derivatives can use without risk of conflict. > > > > > > Reviewed by: jhb, kevans, kib > > > Sponsored by: DARPA > > > Differential Revision: https://reviews.freebsd.org/D27988 > > > --- > > > sys/kern/init_sysent.c | 120 +++++++++++++++++++++++------------------------ > > > sys/kern/syscalls.c | 120 +++++++++++++++++++++++------------------------ > > > sys/kern/syscalls.master | 55 ++++++++++------------ > > > 3 files changed, 145 insertions(+), 150 deletions(-) > > I highly dislike this. You committed both manually edited file and generated > > files in one commit. Can we please avoid this? > > > > It is hard/impossible to read the diff as is. > > While in this case it would be harmless to split the changes, I strongly > disagree with the concept of separating syscalls.master changes and > generated files because in the common case (adding syscalls) it requires > that the first commit break the build. That build breakage is a non-issue, even for bisects. Operator just need to move one commit further. But it makes reading the change significantly harder, which is an artificial pain inflicted on everybody who need to follow (and debug) the code. I do not see why it is useful.