Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Nov 2002 17:18:32 +1030
From:      Greg 'groggy' Lehey <grog@FreeBSD.org>
To:        Bruce Evans <bde@zeta.org.au>
Cc:        Julian Elischer <julian@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sbin/fsck_ffs pass5.c
Message-ID:  <20021126064832.GF49477@wantadilla.lemis.com>
In-Reply-To: <20021126173629.E3086-100000@gamplex.bde.org>
References:  <20021126002007.GZ41068@wantadilla.lemis.com> <20021126173629.E3086-100000@gamplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, 26 November 2002 at 17:59:16 +1100, Bruce Evans wrote:
> On Tue, 26 Nov 2002, Greg 'groggy' Lehey wrote:
>
>> On Monday, 25 November 2002 at 17:00:03 +1100, Bruce Evans wrote:
>>> On Sun, 24 Nov 2002, Julian Elischer wrote:
>>>
>>>> julian      2002/11/24 13:41:42 PST
>>>>
>>>>   Modified files:
>>>>     sbin/fsck_ffs        pass5.c
>>>> ...
>>> Please fix the style bugs (excessive parentheses) in this before merging.
>>
>> I thought there was consensus that additional parentheses were not
>> necessarily a Bad Thing if they served to demonstrate operator
>> precedence, as here.
>
> Here is a patch to fix these style bugs.
>
> ...

I don't think anybody is in doubt about how to change it.

> To me, parenthesizing almost eveything demonstrates that the author
> is not fluent in C.

To me, parenthesizing demonstrates that the author thinks the reader
may not be fluent in C.

Greg
--
See complete headers for address and phone numbers

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20021126064832.GF49477>