From owner-cvs-src@FreeBSD.ORG Sat Nov 24 20:16:57 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8324016A419 for ; Sat, 24 Nov 2007 20:16:57 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from nf-out-0910.google.com (nf-out-0910.google.com [64.233.182.188]) by mx1.freebsd.org (Postfix) with ESMTP id 13F0113C46A for ; Sat, 24 Nov 2007 20:16:56 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: by nf-out-0910.google.com with SMTP id b2so192219nfb for ; Sat, 24 Nov 2007 12:16:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; bh=FztF71Hu3/A9/CQijLGoAeZmi/r+SVlV2r0xrTYY5kY=; b=F/bUIIy5di02RY1eVzdapEr2NdgsIhI1YeilRkYw3RQRbAdVPzZ+/QiebshA/az4AXPaNBcjdgrBHHPxq2LRuaEN4GsVU1lrLJWfDP8MyAGnYyOOzhcZL7CGEC3vhFMLST43CySbL0egnNeleUaaE86onj0VprFHNFuyyp9raU4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=ngu7D9iD7QK2SIHQlhI+FHMZGCfB97Ki1um+B9GXhNhKG4Q0K6aBsUZC2H0QhvRAROhHwynYUnY47JJPx97SIpuTYrNIYRDMC1TBy5tRE4YZ+bunSDfw9JiqzdddOdL8UZQ3esY4ba8SG5cWrKCFVg2rw7CSHf6vWamlf2eYJOY= Received: by 10.86.62.3 with SMTP id k3mr801169fga.1195933851876; Sat, 24 Nov 2007 11:50:51 -0800 (PST) Received: by 10.86.28.19 with HTTP; Sat, 24 Nov 2007 11:50:51 -0800 (PST) Message-ID: <3bbf2fe10711241150y332a202s17d38f05c2c785df@mail.gmail.com> Date: Sat, 24 Nov 2007 20:50:51 +0100 From: "Attilio Rao" Sender: asmrookie@gmail.com To: "Robert Watson" In-Reply-To: <20071124194615.Y14018@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200711240422.lAO4MSGT071285@repoman.freebsd.org> <20071124194615.Y14018@fledge.watson.org> X-Google-Sender-Auth: edeb76d42896195f Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/kern kern_lock.c src/sys/sys lockmgr.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Nov 2007 20:16:57 -0000 2007/11/24, Robert Watson : > On Sat, 24 Nov 2007, Attilio Rao wrote: > > > attilio 2007-11-24 04:22:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_lock.c > > sys/sys lockmgr.h > > Log: > > transferlockers() is a very dangerous and hack-ish function as waiters > > should never be moved by one lock to another. > > As, luckily, nothing in our tree is using it, axe the function. > > > > This breaks lockmgr KPI, so interested, third-party modules should update > > their source code with appropriate replacement. > > > > Ok'ed by: ups, rwatson > > "Ok'd by" doesn't generally seem to be a convention for FreeBSD commit > messages--I'd suggest "discussed with" which makes it seem a bit less like > approval, which is generally captured with "approved by". Though I saw it used several time, ok, thanks. Attilio -- Peace can only be achieved by understanding - A. Einstein