From owner-cvs-src@FreeBSD.ORG  Sat Apr  8 23:43:08 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 48BDC16A401;
	Sat,  8 Apr 2006 23:43:08 +0000 (UTC)
	(envelope-from scottl@samsco.org)
Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B0D1443D48;
	Sat,  8 Apr 2006 23:43:07 +0000 (GMT)
	(envelope-from scottl@samsco.org)
Received: from [192.168.254.14] (imini.samsco.home [192.168.254.14])
	(authenticated bits=0)
	by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k38Nh6eg020176;
	Sat, 8 Apr 2006 17:43:06 -0600 (MDT)
	(envelope-from scottl@samsco.org)
Message-ID: <44384A8A.6000609@samsco.org>
Date: Sat, 08 Apr 2006 17:43:06 -0600
From: Scott Long <scottl@samsco.org>
User-Agent: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US;
	rv:1.7.7) Gecko/20050416
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Nate Lawson <nate@root.org>
References: <20060408022346.A583C16A4E4@hub.freebsd.org>
	<4438444E.7040009@root.org>
In-Reply-To: <4438444E.7040009@root.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-1.4 required=3.8 tests=ALL_TRUSTED autolearn=failed 
	version=3.1.1
X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, Paul Saab <ps@FreeBSD.org>,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/amr amr.c amr_pci.c amrvar.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Apr 2006 23:43:08 -0000

Nate Lawson wrote:

> Paul Saab wrote:
> 
>> ps          2006-04-08 02:23:27 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/dev/amr          amr.c amr_pci.c amrvar.h   Log:
>>   Close a pesky race where after checking the BUSY flag in 
>> amr_wait_command,
>>   the completion of the command can occur before tsleep is called and
>>   the command ends up blocking forever since the wakeup has already
>>   been called.
>>     Submitted by:   ups
>>     Revision  Changes    Path
>>   1.76      +19 -6     src/sys/dev/amr/amr.c
>>   1.35      +1 -0      src/sys/dev/amr/amr_pci.c
>>   1.31      +1 -0      src/sys/dev/amr/amrvar.h
> 
> 
> This would be a good audit task to do on the whole kernel.  There are 
> very few legitimate uses of tsleep() these days.
> 

There are legitimate uses, this just isn't one of them.

Scott