From owner-svn-src-all@FreeBSD.ORG  Mon Feb 24 09:50:56 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx2.freebsd.org (mx2.freebsd.org [8.8.178.116])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id C517CFA0;
 Mon, 24 Feb 2014 09:50:56 +0000 (UTC)
Received: from butcher-nb.yandex.net (hub.freebsd.org
 [IPv6:2001:1900:2254:206c::16:88])
 by mx2.freebsd.org (Postfix) with ESMTP id 4AB9084F;
 Mon, 24 Feb 2014 09:50:55 +0000 (UTC)
Message-ID: <530B15F1.5050300@FreeBSD.org>
Date: Mon, 24 Feb 2014 13:50:41 +0400
From: "Andrey V. Elsukov" <ae@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64;
 rv:24.0) Gecko/20100101 Thunderbird/24.2.0
MIME-Version: 1.0
To: Craig Rodrigues <rodrigc@crodrigues.org>, 
 "Bjoern A. Zeeb" <bz@freebsd.org>
Subject: Re: svn commit: r262351 - head/sys/netinet6
References: <201402230127.s1N1RMoX052542@svn.freebsd.org>	<D23407A9-35AC-4B5A-904D-B1BD333B46C0@FreeBSD.org>
 <CAG=rPVe4J7e192Z9eS+oqhkdZujrVn3t5=JsvJ2PT_VA9TF9bg@mail.gmail.com>
In-Reply-To: <CAG=rPVe4J7e192Z9eS+oqhkdZujrVn3t5=JsvJ2PT_VA9TF9bg@mail.gmail.com>
X-Enigmail-Version: 1.6
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Feb 2014 09:50:56 -0000

On 24.02.2014 12:34, Craig Rodrigues wrote:
> 
> On Feb 23, 2014 2:56 PM, "Bjoern A. Zeeb" <bz@freebsd.org
> <mailto:bz@freebsd.org>> wrote:
>>
>>
>> On 23 Feb 2014, at 01:27 , Craig Rodrigues <rodrigc@FreeBSD.org> wrote:
>>
>> > Author: rodrigc
>> > Date: Sun Feb 23 01:27:22 2014
>> > New Revision: 262351
>> > URL: http://svnweb.freebsd.org/changeset/base/262351
>> >
>> > Log:
>> >  Remove KASSERT from in6p_lookup_mcast_ifp().
>> >
>> >  When the devel/jenkins port, version 1.551 was started,
>> >  the kernel would panic if INVARIANTS was enabled in the kernel config.
>> >
>> >  Suggested by: bms
>>
>> This reads to me “we hit the assert, bms suggested to remove it”.
>  Great!  Caught a bug!  Where is it?  In no way the commit message tells
> me why?   Why did we not hit the assert in the last n years? What has
> changed that we hit it now? Was the assert wrong from the beginning?
>  Did we hit a real bug elsewhere and now lost the tracking for it?
>>
>> Could you please at least for the archives explain?
> 
> Bruce suggested that I remove the KASSERT here:
> 
> http://lists.freebsd.org/pipermail/freebsd-net/2013-October/036806.html

There was my analysis:
http://lists.freebsd.org/pipermail/freebsd-net/2013-August/036545.html

I think it is safe to remove this KASSERT.

-- 
WBR, Andrey V. Elsukov