From owner-cvs-all Tue Aug 14 9: 5:20 2001 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id C538637B407; Tue, 14 Aug 2001 09:05:03 -0700 (PDT) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.2/8.11.2) id f7EG50A54043; Tue, 14 Aug 2001 19:05:00 +0300 (EEST) (envelope-from ru) Date: Tue, 14 Aug 2001 19:05:00 +0300 From: Ruslan Ermilov To: John Baldwin Cc: "Daniel M. Eischen" , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Peter Wemm Subject: Re: cvs commit: src/include stdio.h src/lib/libc Makefilesrc/lib Message-ID: <20010814190500.A53885@sunbay.com> Mail-Followup-To: John Baldwin , "Daniel M. Eischen" , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Peter Wemm References: <3B7918B8.84C6B879@vigrid.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from jhb@FreeBSD.org on Tue, Aug 14, 2001 at 08:58:34AM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Tue, Aug 14, 2001 at 08:58:34AM -0700, John Baldwin wrote: > > On 14-Aug-01 Daniel M. Eischen wrote: > > Peter Wemm wrote: > >> > >> peter 2001/08/13 14:48:44 PDT > >> > >> Modified files: > >> include stdio.h > >> lib/libc Makefile > >> lib/libc/stdio findfp.c > >> Log: > >> Rip out the old __stdin/out/err stuff. It was completely 100% useless. :-( > >> It was foiled because of dynamic copy relocations that caused compile-time > >> space to be reserved in .bss and at run time a blob of data was copied to > >> that space and everything used the .bss version.. The problem is that > >> the space is reserved at compile time, not runtime... So we *still* could > >> not change the size of FILE. Sigh. :-( > >> > >> Replace it with something that does actually work and really does let us > >> make 'FILE' extendable. It also happens to be the same as Linux does in > >> glibc, but has the slight cost of a pointer. Note that this is the > >> same cost that 'fp = fopen(), fprintf(fp, ...); fclose(fp);' has. > >> Fortunately, actual references to stdin/out/err are not all that common > >> since we have implicit stdin/out/err-using versions of functions > >> (printf() vs. fprintf()). > > > > Yes! > > > > So do we allow FILE to be extended only after bumping the library > > version once (after 5.0-release)? And thereafter all extensions to > > FILE do not need a version bump? > > We've already bumped libc for 5.x. Assuming this works ok, we shouldn't need > any further bumps for extending FILE. > I think just bumping __FreeBSD_version should work. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message