Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 13 Apr 2022 09:17:51 +0200
From:      Kristof Provost <kp@FreeBSD.org>
To:        Dimitry Andric <dim@FreeBSD.org>
Cc:        Cy Schubert <Cy.Schubert@cschubert.com>, Shawn Webb <shawn.webb@hardenedbsd.org>, Olivier Cochard <olivier@FreeBSD.org>, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: abdcd967dc0c - main - =?utf-8?Q?Add new french b=C3=A9po keyboard layout (version 1.1rc2) normalized by F=
Message-ID:  <F349165D-B6C0-4DB7-BEAE-0FB88D2A5FBF@FreeBSD.org>
In-Reply-To: <7D4B34D5-63EB-40CC-AF1D-625BE738267C@FreeBSD.org>
References:  <202204121855.23CItxnR091113@gitrepo.freebsd.org> <20220412190504.juclbpyc6xt3q76w@mutt-hbsd> <20220412192917.8614A7E@slippy.cwsent.com> <7D4B34D5-63EB-40CC-AF1D-625BE738267C@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 12 Apr 2022, at 22:42, Dimitry Andric wrote:
> On 12 Apr 2022, at 21:29, Cy Schubert <Cy.Schubert@cschubert.com> wrote=
:
>>
>> In message <20220412190504.juclbpyc6xt3q76w@mutt-hbsd>, Shawn Webb wri=
tes:
>>>
>>> --domzta7c4zc4deqc
>>> Content-Type: text/plain; charset=3Dutf-8
>>> Content-Disposition: inline
>>> Content-Transfer-Encoding: quoted-printable
>>>
>>> Um, What happened here?
>>
>> Looks like some garbage got inserted into the header causing some head=
er
>> lines to be considered part of the body.
>
> Looks to me like the commit mailer can't handle it when there is no
> empty line between the body of the commit message and the "PR:",
> "Approved by:", etc headers.
>
I think we=E2=80=99ve seen that before, without issue.

My guess is that it=E2=80=99s a bug in the post-commit script that genera=
tes the e-mail.

The first line of the commit has utf-8 characters in it. Sending utf-8 in=
 a subject line requires a =3D?charset? prefix. That was added here, but =
then the =E2=80=98git: hash - branch -=E2=80=98 prefix was added afterwar=
ds.

Kristof



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F349165D-B6C0-4DB7-BEAE-0FB88D2A5FBF>