Date: Thu, 29 May 2014 16:36:19 +0800 From: Kevin Lo <kevlo@FreeBSD.org> To: Jason Hellenthal <jhellenthal@dataix.net> Cc: "freebsd-net@freebsd.org" <freebsd-net@freebsd.org>, adrian@freebsd.org, "\[FreeBSD Stable\]" <freebsd-stable@freebsd.org>, jhb@freebsd.org Subject: Re: [VIMAGE][udplite] FreeBSD 10-STABLE/powerpc Message-ID: <20140529083619.GA8437@ns.kevlo.org> In-Reply-To: <CAO2cuEPMy6KfeVj9O22fn3%2BM5P%2BFWaaO%2BcLHud9HGd%2Br-L2J%2Bg@mail.gmail.com> References: <CAO2cuEPMy6KfeVj9O22fn3%2BM5P%2BFWaaO%2BcLHud9HGd%2Br-L2J%2Bg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 29, 2014 at 02:34:47AM -0400, Jason Hellenthal wrote:
> Is anyone aware that VIMAGE on powerpc is currently broken ?
Hi Jason,
Did you mean that compile VIMAGE support into your kernel will fail?
If so, what compiler do you use? Thanks.
>
> In file included from /export/usr/src/sys/netinet/in_proto.c:83:
> /export/usr/src/sys/netinet/udp_var.h: In function 'get_inpcbinfo':
> /export/usr/src/sys/netinet/udp_var.h:153: error: dereferencing pointer to
> incomplete type
> /export/usr/src/sys/netinet/udp_var.h:153: error: dereferencing pointer to
> incomplete type
> /export/usr/src/sys/netinet/udp_var.h: In function 'get_pcblist':
> /export/usr/src/sys/netinet/udp_var.h:159: error: dereferencing pointer to
> incomplete type
> /export/usr/src/sys/netinet/udp_var.h:159: error: dereferencing pointer to
> incomplete type
> *** Error code 1
>
> The relevant code in that header is:
> get_inpcbinfo(uint8_t protocol)
> {
> return (protocol == IPPROTO_UDP) ? &V_udbinfo : &V_ulitecbinfo;
> }
>
> get_pcblist(uint8_t protocol)
> {
> return (protocol == IPPROTO_UDP) ? &V_udb : &V_ulitecb;
> }
>
> Working Copy Root Path: /usr/src
> URL: svn://svn.freebsd.org/base/stable/10
> Relative URL: ^/stable/10
> Repository Root: svn://svn.freebsd.org/base
> Repository UUID: ccf9f872-aa2e-dd11-9fc8-001c23d0bc1f
> Revision: 266818
> Node Kind: directory
> Schedule: normal
> Last Changed Author: delphij
> Last Changed Rev: 266816
> Last Changed Date: 2014-05-28 14:51:49 -0400 (Wed, 28 May 2014)
>
> Also looking at svn it appears to have come from this commit... I have
> backed out the change here and it appears to be following through so more
> attention to VIMAGE and udplite seems to be needed.
>
> ------------------------------------------------------------------------
> r265946 | kevlo | 2014-05-13 02:05:53 -0400 (Tue, 13 May 2014) | 14 lines
> Changed paths:
> M /stable/10
> M /stable/10/lib/libc/net/getaddrinfo.c
> M /stable/10/sys/netinet/in.c
> M /stable/10/sys/netinet/in.h
> M /stable/10/sys/netinet/in_pcb.c
> M /stable/10/sys/netinet/in_proto.c
> M /stable/10/sys/netinet/udp_usrreq.c
> M /stable/10/sys/netinet/udp_var.h
> A /stable/10/sys/netinet/udplite.h (from
> /head/sys/netinet/udplite.h:264212)
> M /stable/10/sys/netinet6/in6_ifattach.c
> M /stable/10/sys/netinet6/in6_proto.c
> M /stable/10/sys/netinet6/udp6_usrreq.c
> M /stable/10/sys/netinet6/udp6_var.h
> M /stable/10/sys/sys/param.h
>
> MFC r264212,r264213,r264248,r265776,r265811,r265909:
>
> - Add support for UDP-Lite protocol (RFC 3828) to IPv4 and IPv6 stacks.
> Tested with vlc and a test suite [1].
> [1] http://www.erg.abdn.ac.uk/~gerrit/udp-lite/files/udplite_linux.tar.gz
>
> Reviewed by: jhb, glebius, adrian
>
> - Fix a logic bug which prevented the sending of UDP packet with 0 checksum.
>
> - Disable TX checksum offload for UDP-Lite completely. It wasn't used for
> partial checksum coverage, but even for full checksum coverage it doesn't
> work.
>
> ------------------------------------------------------------------------
Kevin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140529083619.GA8437>