From owner-freebsd-current Sat Dec 26 09:12:08 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id JAA13002 for freebsd-current-outgoing; Sat, 26 Dec 1998 09:12:08 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from janus.syracuse.net (janus.syracuse.net [205.232.47.15]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id JAA12995 for ; Sat, 26 Dec 1998 09:12:06 -0800 (PST) (envelope-from green@unixhelp.org) Received: from localhost (green@localhost) by janus.syracuse.net (8.8.8/8.8.7) with ESMTP id MAA21530; Sat, 26 Dec 1998 12:11:47 -0500 (EST) Date: Sat, 26 Dec 1998 12:11:46 -0500 (EST) From: Brian Feldman X-Sender: green@janus.syracuse.net To: Bruce Evans cc: current@FreeBSD.ORG Subject: Re: revoke of fifos In-Reply-To: <199812260452.PAA17319@godzilla.zeta.org.au> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Sat, 26 Dec 1998, Bruce Evans wrote: > >> >revoke(2) on VFIFO types is broken now, leading to stranded mbuf's. I suppose > >> > >> I don't think it has ever worked in BSD. > > > >Nor should it need to since, according to revoke.2: > > Access to a file may be revoked only by its owner or the super user. The > > revoke() function is currently supported only for block and character > > special device files. > > The restriction to special files was removed in Lite2, but the man page was > not updated and revoke on fifos didn't actually work. So is the solution to update the manpage and: a. note that only revoking FIFOs doesn't work, also checking for vp->VFIFO in vfs_syscalls.c:/^revoke? or b. Take all notes about file revocation not working out, and correct the case of revoking VFIFOs by not stranding those mbufs? > > Bruce > Brian Feldman _ __ ___ ___ ___ green@unixhelp.org _ __ ___ | _ ) __| \ http://www.freebsd.org/ _ __ ___ ____ | _ \__ \ |) | FreeBSD: The Power to Serve! _ __ ___ ____ _____ |___/___/___/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message