From owner-svn-src-all@freebsd.org Mon Jun 17 17:47:11 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 607C415C0C7C for ; Mon, 17 Jun 2019 17:47:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x831.google.com (mail-qt1-x831.google.com [IPv6:2607:f8b0:4864:20::831]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id F13AF746B0 for ; Mon, 17 Jun 2019 17:47:10 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x831.google.com with SMTP id p15so11788123qtl.3 for ; Mon, 17 Jun 2019 10:47:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CZ718nch003tapjLCQBtXkcyMeXI6VwB2g+BTwdmE2Q=; b=rJhJj9EGkevInZMWDPfSrT18r/UVFKv2Ef+8cw7R6Ey9s/PVEZG70j6joF6EAKV77Y 40QcYXsdRBWDoKO4vksGnbQgedUHC97kidnvoF3tnYLzCqTjVuhIqsaF38TFbsPOhiIl XREpsMv1LqwRXWTW1qKlZx+EqlQb10xJbfhsArsPJhvXVXYF7lCLizjTa3BhdzLfxgSJ pmWWj9Optd/nTHGP8IbEY9bULj9C9vT31DhktlnrCUoUdP4KaeWfTMKtPmThKfoIf5B0 C1GftK86n8hpZTmTUqIqfelXu6gDC26OYl8jURCWAPM/1nfMqSsCChAUrAJac1sZzaol HJxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CZ718nch003tapjLCQBtXkcyMeXI6VwB2g+BTwdmE2Q=; b=kchi/ZhwAjaO0RGy8BBW9S2PerMi+cDB1ZhDKB/1WtlWTpMgUuUvd3FpI6QahGYR2G Q/vgh3Ngm04fB3fqeLkTHv/KCkYU23TC2g4DXcLnwxFwoaHLymyP1WOnj5EwytrW8bp0 XsCZuCwhR6s/KJtVOhfcSZ2Y0iWAYJ9sGWjmVZ+w+Ed3tg9EN9fYizfhfmeeNwwjVbMf dFtMf60veGxOGvjR1hxjetq8oSHazn/zadkJO+JFmSETve5u1oWSnc9jdYRHoGtdruTE Rgxd7S7RCUVAIOrG1RYd9YaB70CK/+j3tNwC2E792fQ6wkVMihsZuHuSJQozjgz8XX2e XHCg== X-Gm-Message-State: APjAAAW1vHXMaVvPGBs8DUa2KlwC7kGuBZewKACVDkYjFPl/FVVXRBoN uSzX6rMEXtItS4yZ/5ZbNHg+r17Ixxv3Pwcu0J6otFWACAk= X-Google-Smtp-Source: APXvYqzdidCGu5nShtibCPTzlk2xhhLwiniU06VH3CmiakZQZN8D1/EDmUjcZJcRaN0O7AkiCGihFKQk2MdY2dk4Ey8= X-Received: by 2002:a0c:9230:: with SMTP id a45mr22453156qva.188.1560793627209; Mon, 17 Jun 2019 10:47:07 -0700 (PDT) MIME-Version: 1.0 References: <201906171654.x5HGsqQm003736@repo.freebsd.org> <223A02B4-20E2-4973-B3E1-9E5D8E1B0D20@samsco.org> In-Reply-To: <223A02B4-20E2-4973-B3E1-9E5D8E1B0D20@samsco.org> From: Warner Losh Date: Mon, 17 Jun 2019 10:46:54 -0700 Message-ID: Subject: Re: svn commit: r349146 - head/share/man/man4 To: Scott Long Cc: Niclas Zeising , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org X-Rspamd-Queue-Id: F13AF746B0 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.98)[-0.978,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jun 2019 17:47:11 -0000 Especially since there can be multiple PCI registers that can be read in 1 32-bit transaction. Warner On Mon, Jun 17, 2019, 10:28 AM Scott Long wrote: > It=E2=80=99s customary to refer to PCI configuration registers in the plu= ral > form. Would > you mind changing back from =E2=80=9Cregister=E2=80=9D to =E2=80=9Cregist= ers=E2=80=9D? > > Thanks, > Scott > > > > On Jun 17, 2019, at 10:54 AM, Niclas Zeising > wrote: > > > > Author: zeising (doc,ports committer) > > Date: Mon Jun 17 16:54:51 2019 > > New Revision: 349146 > > URL: https://svnweb.freebsd.org/changeset/base/349146 > > > > Log: > > pci.4: wordsmith and add missing words > > > > Add missing words after PCI in the description of the PCIOCWRITE and > > PCIOCATTACHED ioctls. > > Use singular in PCIOCREAD, we only read one register at the time. > > > > Reviewed by: bcr, bjk, rgrimes, cem > > MFC after: 2 weeks > > X-MFC-with: r349133 > > Differential Revision: https://reviews.freebsd.org/D20671 > > > > Modified: > > head/share/man/man4/pci.4 > > > > Modified: head/share/man/man4/pci.4 > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > --- head/share/man/man4/pci.4 Mon Jun 17 16:50:58 2019 (r349145) > > +++ head/share/man/man4/pci.4 Mon Jun 17 16:54:51 2019 (r349146) > > @@ -290,7 +290,7 @@ This > > .Xr ioctl 2 > > reads the > > .Tn PCI > > -configuration registers specified by the passed-in > > +configuration register specified by the passed-in > > .Va pci_io > > structure. > > The > > @@ -323,7 +323,7 @@ This > > .Xr ioctl 2 > > allows users to write to the > > .Tn PCI > > -specified in the passed-in > > +configuration register specified in the passed-in > > .Va pci_io > > structure. > > The > > @@ -338,7 +338,7 @@ This > > .Xr ioctl 2 > > allows users to query if a driver is attached to the > > .Tn PCI > > -specified in the passed-in > > +device specified in the passed-in > > .Va pci_io > > structure. > > The > > > > >