From owner-svn-src-all@freebsd.org Mon Sep 19 18:58:00 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 521B8BE00AC for ; Mon, 19 Sep 2016 18:58:00 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yw0-x229.google.com (mail-yw0-x229.google.com [IPv6:2607:f8b0:4002:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 122968E9 for ; Mon, 19 Sep 2016 18:58:00 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yw0-x229.google.com with SMTP id t67so157597914ywg.3 for ; Mon, 19 Sep 2016 11:58:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=cEPK4PYnnaCY3Z6GN82XRMS9f5gM627duQc+WWrtCuU=; b=Ma2Ve4PWArde7KqFzP+guYQ7G0gs+Zc2hmHg2HVwqxSL6wSZsbX5LUpcM89kJRmhY7 VYHb3FP7QhwWzPCCPAPn67mLo8sAlFWX74DxAS7uuh5vhCda1wy/h7fKs08Jw/4c8z3C bJ2QD6pJERXQroPrlOC1kzu8dGTzVsoSI/IwO7dBHLtPR2FXU1l0a8gCiaLwI2tmEEVl rbdgbrfdbNH1Oc5H6MR5UxELsnhVOBMOf+gf36kAwNJt5mfYmpDBfRUfB/VfGnmdBHzS nIsTTj51N/GJHBHKgLfv3AW/Mg8CMWwC8PQOKPmenHfaEUU7TpIY7j3RSTnaPtJUFtcn neqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=cEPK4PYnnaCY3Z6GN82XRMS9f5gM627duQc+WWrtCuU=; b=a6eY+kCDjrfkijZVGyH4plvyLcxDEt502x8dl50FfmmG8xbwrrLk5Mxc19puQphLFl JgAPR0hv257l0/qdVyiaL8798qKwdPBcDvnr3dnovnISMV8a93DmFsz7BbqY2EJiFyOk UX447JK0KYyUZzLGKErlaYb6ZjyQzkWj95lndfgO761apwjCcytscBfSydJXjY93V9uc sPI7EBHgCA6kg/H+BZQFQphaHYBIF9bVug8ipt9xDbh74AbmAZvrF1fdxgg1OMfDYtnt 8+Lc4cBE20k3bEaFW3pZgb1wQK+hfRyGuvTj/uxj0513Tuu/qm87BdM/H0ZHNofUbIVt 73OQ== X-Gm-Message-State: AE9vXwPJwuGEsw8Igav9R4NoZpsFwCPWqgaEVs0pYTHamhWRGBCKs5PhQf5put+9bQChH29KXb/MCH3Rfwp7hQ== X-Received: by 10.13.255.69 with SMTP id p66mr28378734ywf.173.1474311479217; Mon, 19 Sep 2016 11:57:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.13.201.71 with HTTP; Mon, 19 Sep 2016 11:57:58 -0700 (PDT) In-Reply-To: <201609191234.u8JCYTUo052934@repo.freebsd.org> References: <201609191234.u8JCYTUo052934@repo.freebsd.org> From: Ed Schouten Date: Mon, 19 Sep 2016 20:57:58 +0200 Message-ID: Subject: Re: svn commit: r305971 - stable/11/lib/msun/src To: Bruce Evans Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Sep 2016 18:58:00 -0000 Hi Bruce, 2016-09-19 14:34 GMT+02:00 Bruce Evans : > +#if (LDBL_MANT_DIG == 53) > +__weak_reference(fmod, fmodl); > +#endif I've noticed that libm uses __weak_reference() all over the place, but I guess that in this specific case there is no reason to use them, right? Wouldn't it make more sense to use strong references here, so that they are consistent with other architectures? -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717