From owner-svn-src-head@freebsd.org Sun Mar 3 21:42:21 2019 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B7557151D9AA; Sun, 3 Mar 2019 21:42:20 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 459006F1E6; Sun, 3 Mar 2019 21:42:18 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id 0Ys4htSCThfkP0Ys5hUeTJ; Sun, 03 Mar 2019 14:42:10 -0700 X-Authority-Analysis: v=2.3 cv=RKLN4Lq+ c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=8nJEP1OIZ-IA:10 a=NTGMnVQrEZIA:10 a=6I5d2MoRAAAA:8 a=ASrO2z8EAAAA:8 a=YxBL1-UpAAAA:8 a=GRRj7yhdenHdc00NboEA:9 a=wPNLvfGTeEIA:10 a=IjZwj45LgO3ly-622nXo:22 a=hMlqHZxbFqNCaWTKXPQf:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTPS id 55CE3410; Sun, 3 Mar 2019 13:42:07 -0800 (PST) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id x23Lg635087505; Sun, 3 Mar 2019 13:42:06 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id x23Lg6Xf087501; Sun, 3 Mar 2019 13:42:06 -0800 (PST) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201903032142.x23Lg6Xf087501@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Ian Lepore cc: Enji Cooper , Steven Hartland , Alexey Dokuchaev , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344701 - head/sbin/camcontrol In-Reply-To: Message from Ian Lepore of "Sun, 03 Mar 2019 13:28:41 -0700." <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Date: Sun, 03 Mar 2019 13:42:06 -0800 X-CMAE-Envelope: MS4wfF2yxYOVI2z2Yp47k5itcuK4Ug9tJD01CNGXK9C1cSd7/arg8xuv+fLmOUmjPYZtOsuA7/EH3yQkLySw45gDUZjo/fN7lDiLvzn/8F2vgP48sEnC74fX Xj8V1xwnr4j2O5Vab2DCN1DnbODrpyls0VBOLzclEkpQN9I7fkKs3iQoKRgJQqhtEJzYIeUqS30yLwF8IaK/88osxeLZBbYOBnnKTOn2GH9CDbGmzIR9o0s3 jJBXKSMvW0PXz1LoS45XRpw3RTa634fogKbNZO/1/KLO4rwseLttRmoxUNOJBPDDJQX+v5zXl9DcoPYUr95b2cvg2xZ2Z9y+Z1iJTLkeCqjI2Gg/MgjY3wua Y2bwwOLN7SAguJ1PoVSXrOYFhEp+rA== X-Rspamd-Queue-Id: 459006F1E6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-4.41 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; TO_DN_SOME(0.00)[]; MV_CASE(0.50)[]; HAS_XAW(0.00)[]; MX_GOOD(-0.01)[spqr.komquats.com]; NEURAL_HAM_SHORT(-0.69)[-0.691,0]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_LOW(-0.10)[139.136.59.64.list.dnswl.org : 127.0.5.1]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:6327, ipnet:64.59.128.0/20, country:CA]; MIME_TRACE(0.00)[0:+]; RECEIVED_SPAMHAUS_PBL(0.00)[17.125.67.70.zen.spamhaus.org : 127.0.0.11]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; RCVD_COUNT_FIVE(0.00)[5]; REPLYTO_EQ_FROM(0.00)[]; FROM_HAS_DN(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; IP_SCORE(-2.01)[ip: (-5.03), ipnet: 64.59.128.0/20(-2.75), asn: 6327(-2.16), country: CA(-0.09)]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[]; FREEMAIL_CC(0.00)[gmail.com]; RCVD_TLS_LAST(0.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 03 Mar 2019 21:42:21 -0000 In message <06d7e6402ad6f673b15873a9d99c9382f21e64b9.camel@freebsd.org> , Ian Le pore writes: > On Sun, 2019-03-03 at 12:20 -0800, Enji Cooper wrote: > > > On Mar 3, 2019, at 11:12, Steven Hartland > > > wrote: > > > > > > Not really much more to say that isn't explained by that and the > > > code. > > > > > > Sure I could have used a different sentence structure for the body > > > but it wouldn't add anything IMO, thoughts? > > > > Why the previous sector size was wrong isn’t clear from the > > commit message. Why switch from a sizeof to 0? > > Cheers! > > -Enji > > > > The commit message said it was "incorrect / unused". While a bit terse, > it does communicate that the old value was incorrect (by being there at > all) because the value is unused (so zero more clearly expresses that). > > It's not completely a joke that most English-speaking software > engineers have English as a second language. :) This is one of those profound quotes that should be in fortune(1). -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.