From owner-freebsd-arch@FreeBSD.ORG Sat Jun 12 17:18:07 2010 Return-Path: Delivered-To: arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D24021065678 for ; Sat, 12 Jun 2010 17:18:07 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 3634F8FC12 for ; Sat, 12 Jun 2010 17:18:06 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id o5CHI30O010492; Sat, 12 Jun 2010 11:18:03 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Sat, 12 Jun 2010 11:18:05 -0600 (MDT) Message-Id: <20100612.111805.94843338670897167.imp@bsdimp.com> To: jroberson@jroberson.net From: "M. Warner Losh" In-Reply-To: <20100612.101458.10150326125744273.imp@bsdimp.com> References: <20100612.101458.10150326125744273.imp@bsdimp.com> X-Mailer: Mew version 6.3 on Emacs 22.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: arch@FreeBSD.org Subject: Re: Change to config(8) for OFED X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Jun 2010 17:18:07 -0000 In message: <20100612.101458.10150326125744273.imp@bsdimp.com> "M. Warner Losh" writes: : In message: : Jeff Roberson writes: : : I have a patch to permit compilation of files brought in from linux : : that use the same name in multiple directories. I added a new : : directive called 'obj-prefix' which expects a quoted string that will : : be prepended to the object file name. The problem is that this breaks : : ${.IMPSRC} : : So foo_bar.o depends on bar.c? And ${.IMPSRC} expands to foo_bar.c? : : : I could also emit the source file name for those rules which are : : created with prefixes and then require each file that uses a prefix to : : also use compile-with. This wouldn't be so bad since they likely are : : already using compile-with anyway. : : You'll have to emit compile rules, I think. Ideally, you'd be able to emit: foo_bar.o: $S/path/to/file/bar.c ${NORMAL_C} @${NORMAL_CTFCONVERT} but NORMAL_C is NORMAL_C= ${CC} -c ${CFLAGS} ${WERROR} ${PROF} ${.IMPSRC} and .IMPSRC is null. That seems like a bug to me, but I'm not sure if the bug is that .IMPSRC is computed wrong, or if it really should be ${.ALLSRC} Warner