From owner-freebsd-arch@FreeBSD.ORG Sun Apr 11 00:11:12 2010 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D4DCC1065674; Sun, 11 Apr 2010 00:11:12 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from qw-out-2122.google.com (qw-out-2122.google.com [74.125.92.24]) by mx1.freebsd.org (Postfix) with ESMTP id 789118FC08; Sun, 11 Apr 2010 00:11:12 +0000 (UTC) Received: by qw-out-2122.google.com with SMTP id 5so1529776qwi.7 for ; Sat, 10 Apr 2010 17:11:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:received:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=8gxnK0d7rbLEIRfuE1EVz0l04lWadfi4RG05uAbap5g=; b=RWLfBEYiaiOsD4OUXeDSByObwiBV6kdyK0CMULwHfcPnBaHoKxDnH/MSKIEyGaUapN PzOnhjvRAuz/jgJnC3GRWP3mode7RciXOU9dmsgonBsp8XibvCbhILKpdxum4p6YxeGN rimiP6CTI+0Z1yn9LJNtIMdsX8nDlY/ENKpWE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=FzJX3uI43SKL2LijowK8XQ2HzoYpA9tG0CSU2zb1b91CwY0xi+NSx3iKwF+hsFCRsj 5xNMT3nmF+PkXaFoEevYuzoje78/w520VFvPmVckV59sKSFSeeFMt7DUfP9GF2qfqyJy oCrZ+AjHcxd8bvUWmn5ctUUD9xSTPBMZGZdxk= MIME-Version: 1.0 Received: by 10.229.28.85 with HTTP; Sat, 10 Apr 2010 17:11:11 -0700 (PDT) In-Reply-To: References: Date: Sat, 10 Apr 2010 17:11:11 -0700 Received: by 10.229.226.1 with SMTP id iu1mr3210885qcb.19.1270944671710; Sat, 10 Apr 2010 17:11:11 -0700 (PDT) Message-ID: From: Garrett Cooper To: arch@freebsd.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: portmgr@freebsd.org Subject: Re: [RFC] Remove @owner and @user from package list X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 11 Apr 2010 00:11:12 -0000 On Sat, Apr 10, 2010 at 5:08 PM, Garrett Cooper wrote: > On Sat, Apr 10, 2010 at 3:57 PM, Garrett Cooper wrot= e: >> On Sat, Apr 10, 2010 at 3:52 PM, Garrett Cooper wro= te: >>> Hi again arch, >>> =A0 =A0When doing some research, it appears that while functionality in >>> theory exists for @owner and @user in the package list, it isn't >>> actually used in the pkg_install code at all, adding unnecessary bloat >>> to package lists; >>> =A0 =A0FWIW this functionality (just like @exec and @unexec) can be >>> implemented via pkg-install or more reliably via an mtree file. >>> =A0 =A0Thoughts? >> >> Nevermind; I was misreading the code. > > =A0 =A0Doing some more digging, there are a handful of ports that I don't > have installed that implement this functionality: > > @mode ... > > $ grep -Ilr @mode /scratch/freebsd/ports/ | sed 's,/scratch/freebsd/ports= /,,g' > databases/phpmyadmin/pkg-plist-chunk > databases/phpmyadmin211/pkg-plist-chunk > devel/libtai/pkg-plist > dns/poweradmin/pkg-plist-chunk > games/columns/pkg-plist > games/falconseye/pkg-plist > games/glasteroids/pkg-plist > games/nethack32/pkg-plist > games/nethack33/pkg-plist > games/nethack34/pkg-plist > games/omega/pkg-plist > games/sol/pkg-plist > games/wanderer/pkg-plist > games/xmines/pkg-plist > games/zangband/pkg-plist > irc/inspircd/pkg-plist > japanese/nethack32/pkg-plist > japanese/nethack34/pkg-plist > japanese/zangband/pkg-plist > net/phpldapadmin/pkg-plist-chunk > net/phpldapadmin098/pkg-plist-chunk > security/cyrus-sasl2-saslauthd/pkg-plist > sysutils/clockspeed/pkg-plist > www/ssserver/pkg-plist > > @owner ... > > $ grep -Ilr @owner /scratch/freebsd/ports/ | sed 's,/scratch/freebsd/port= s/,,g' > games/omega/pkg-plist > games/sol/pkg-plist > games/zangband/pkg-plist > japanese/zangband/pkg-plist > net/mediatomb/pkg-plist > news/cnews/pkg-plist > news/ifmail/pkg-plist > > =A0 =A0Also, I'm not positive, but I think that none of the released > packages use this either -- so ultimately this functionality could be > removed without any impact to folks unless there's a 3rd party that > has implemented this outside of FreeBSD. This functionality could be > delivered in mtree files, could be fixed with the upstream > installation Makefiles, and IMO should not be as part of the package > list, as it only obscures precedence, ownership, and permissions, and > there's a great deal of overlap involved in package creation and > installation; tar applies permissions bits and ownership, mtree is > called next to fix permissions and ownership, if the mtree file > exists, then the @owner and @mode stuff implements a hammer solution > over a series of files -- note that chmod -R and chown -R are called > with @owner and @mode :( : > > =A0 =A0if (Mode) > =A0 =A0 =A0 =A0if (vsystem("cd %s && /bin/chmod -R %s %s", cd_to, Mode, a= rg)) > =A0 =A0 =A0 =A0 =A0 =A0warnx("couldn't change modes of '%s' to '%s'", arg= , Mode); > =A0 =A0if (Owner && Group) { > =A0 =A0 =A0 =A0if (vsystem("cd %s && /usr/sbin/chown -R %s:%s %s", cd_to, > Owner, Group, arg)) > =A0 =A0 =A0 =A0 =A0 =A0warnx("couldn't change owner/group of '%s' to '%s:= %s'", > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 arg, Owner, Group); > =A0 =A0 =A0 =A0return; > =A0 =A0} > =A0 =A0if (Owner) { > =A0 =A0 =A0 =A0if (vsystem("cd %s && /usr/sbin/chown -R %s %s", cd_to, Ow= ner, arg)) > =A0 =A0 =A0 =A0 =A0 =A0warnx("couldn't change owner of '%s' to '%s'", arg= , Owner); > =A0 =A0 =A0 =A0return; > =A0 =A0} else if (Group) > =A0 =A0 =A0 =A0if (vsystem("cd %s && /usr/bin/chgrp -R %s %s", cd_to, Gro= up, arg)) > =A0 =A0 =A0 =A0 =A0 =A0warnx("couldn't change group of '%s' to '%s'", arg= , Group); Sorry -- forgot @group... $ grep -Ilr @group /scratch/freebsd/ports/ | sed 's,/scratch/freebsd/ports/= ,,g' biology/p5-bioperl/files/patch-Bio-Root-Build.pm databases/phpmyadmin/pkg-plist-chunk databases/phpmyadmin211/pkg-plist-chunk games/falconseye/pkg-plist games/omega/pkg-plist games/sol/pkg-plist games/wanderer/pkg-plist games/zangband/pkg-plist irc/inspircd/pkg-plist japanese/gawk/files/patch-sec1 japanese/zangband/pkg-plist lang/tcc/files/texi2pod.pl mail/sendmail/pkg-plist mail/vpopmail/pkg-install mail/vpopmail-devel/pkg-install math/freemat/pkg-plist net/freebsd-uucp/pkg-plist net/mediatomb/pkg-plist net/phpldapadmin/pkg-plist-chunk net/phpldapadmin098/pkg-plist-chunk news/cnews/pkg-plist news/ifmail/pkg-plist security/sfs/pkg-plist Thanks, -Garrett