From owner-svn-src-stable@freebsd.org Mon Mar 5 18:20:51 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 49927F45025; Mon, 5 Mar 2018 18:20:51 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E434A8727E; Mon, 5 Mar 2018 18:20:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id BD34810A7DB; Mon, 5 Mar 2018 13:20:49 -0500 (EST) From: John Baldwin To: Eitan Adler Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r330451 - in stable/11/sys: dev/iwm dev/otus dev/usb/wlan net80211 Date: Mon, 05 Mar 2018 10:08:04 -0800 Message-ID: <1861296.ksaTdANMae@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <201803050754.w257swAE001435@repo.freebsd.org> References: <201803050754.w257swAE001435@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 05 Mar 2018 13:20:49 -0500 (EST) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2018 18:20:51 -0000 On Monday, March 05, 2018 07:54:58 AM Eitan Adler wrote: > Author: eadler > Date: Mon Mar 5 07:54:57 2018 > New Revision: 330451 > URL: https://svnweb.freebsd.org/changeset/base/330451 > > Log: > MFC r306837: > > [net80211] extend the ieee80211_rx_stats struct to include more information. Have you thought about the KBI implications of this change and some of the other changes you've merged? In theory we try to not break existing kernel modules on a stable branch. That is, one should be able to kldload an if_iwn.ko built on 11.0 on a 11-stable kernel. If this structure is used by any device drivers directly then changing its layout would seem to break existing modules that were built against the old ABI and pass in pointers to the old structures to functions in the kernel. There are some fuzzy areas in the ABI we try to preserve, but we generally try to keep drivers working. Also, we may choose to break the ABI if there is a strong argument for it, but then that is usually something discussed with re@ and noted in the commit log and UPDATING. -- John Baldwin