From owner-freebsd-current@freebsd.org Thu Jul 9 06:05:29 2015 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCF41995624 for ; Thu, 9 Jul 2015 06:05:29 +0000 (UTC) (envelope-from okuno.kohji@jp.panasonic.com) Received: from smtp.mei.co.jp (smtp.mei.co.jp [133.183.100.20]) by mx1.freebsd.org (Postfix) with ESMTP id 6B35B1D1B for ; Thu, 9 Jul 2015 06:05:28 +0000 (UTC) (envelope-from okuno.kohji@jp.panasonic.com) Received: from mail-gw.jp.panasonic.com ([157.8.1.157]) by smtp.mei.co.jp (8.12.11.20060614/3.7W/kc-maile11) with ESMTP id t6965L3Q023039 for ; Thu, 9 Jul 2015 15:05:21 +0900 (JST) Received: from epochmail.jp.panasonic.com ([157.8.1.130]) by mail.jp.panasonic.com (8.11.6p2/3.7W/kc-maili11) with ESMTP id t6965Li31320 for ; Thu, 9 Jul 2015 15:05:21 +0900 Received: by epochmail.jp.panasonic.com (8.12.11.20060308/3.7W/lomi14) id t6965LxI032521; Thu, 9 Jul 2015 15:05:21 +0900 Received: from localhost by lomi14.jp.panasonic.com (8.12.11.20060308/3.7W) with ESMTP id t6965LFs032495; Thu, 9 Jul 2015 15:05:21 +0900 Date: Thu, 09 Jul 2015 15:05:20 +0900 (JST) Message-Id: <20150709.150520.1823457260978955949.okuno.kohji@jp.panasonic.com> To: freebsd-current@freebsd.org Cc: okuno.kohji@jp.panasonic.com Subject: Why shoud we cause panic in scsi_da.c? From: Kohji Okuno Organization: Panasonic Corporation X-Mailer: Mew version 6.5 on Emacs 24.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 06:05:29 -0000 Hi, I found panic() in scsi_da.c. Please find the following. I think we should return with error without panic(). What do you think about this? scsi_da.c: 3018 } else if (bp != NULL) { 3019 if ((done_ccb->ccb_h.status & CAM_DEV_QFRZN) != 0) 3020 panic("REQ_CMP with QFRZN"); Best regards, Kohji Okuno