From owner-cvs-all Tue Nov 27 9:10:42 2001 Delivered-To: cvs-all@freebsd.org Received: from peter3.wemm.org (c1315225-a.plstn1.sfba.home.com [24.14.150.180]) by hub.freebsd.org (Postfix) with ESMTP id 7D63437B405; Tue, 27 Nov 2001 09:10:32 -0800 (PST) Received: from overcee.netplex.com.au (overcee.wemm.org [10.0.0.3]) by peter3.wemm.org (8.11.0/8.11.0) with ESMTP id fARHAWM76602; Tue, 27 Nov 2001 09:10:32 -0800 (PST) (envelope-from peter@wemm.org) Received: from wemm.org (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 35CCB38FD; Tue, 27 Nov 2001 09:10:32 -0800 (PST) (envelope-from peter@wemm.org) X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/libpam/libpam pam_item.c In-Reply-To: Date: Tue, 27 Nov 2001 09:10:32 -0800 From: Peter Wemm Message-Id: <20011127171032.35CCB38FD@overcee.netplex.com.au> Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Dag-Erling Smorgrav wrote: > Dag-Erling Smorgrav writes: > > Log: > > It's idiotic to return PAM_PERM_DENIED when the item argument is NULL; > > PAM_BUF_ERR is much closer to the truth. > > > > Revision Changes Path > > 1.2 +102 -81 src/contrib/libpam/libpam/pam_item.c > > Gah. Major CVS screwup. Nope, its the way cvs works and is the consequence of trivial touching of files on vendor branches. See committers rules, #12: "* Do not commit to anything under the src/contrib, src/crypto, and src/sys/ contrib trees without explicit approval from the respective maintainer(s). The trees mentioned above are for contributed software usually imported onto a vendor branch. Committing something there, even if it does not take the file off the vendor branch, may cause unnecessary headaches for those responsible for maintaining that particular piece of software. Thus, unless you have explicit approval from the maintainer (or you are the maintainer), do not commit there!" Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message