From owner-svn-src-all@freebsd.org  Tue Jan  9 17:43:53 2018
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 62270E66349;
 Tue,  9 Jan 2018 17:43:53 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from mail.baldwin.cx (bigwig.baldwin.cx [96.47.65.170])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 3DECF63CD9;
 Tue,  9 Jan 2018 17:43:53 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from ralph.baldwin.cx (astound-66-234-199-215.ca.astound.net
 [66.234.199.215])
 by mail.baldwin.cx (Postfix) with ESMTPSA id 19B8810A8C2;
 Tue,  9 Jan 2018 12:43:52 -0500 (EST)
From: John Baldwin <jhb@freebsd.org>
To: Warner Losh <imp@bsdimp.com>
Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r327705 - head/stand/mips/beri/common
Date: Tue, 09 Jan 2018 09:05:56 -0800
Message-ID: <1620808.I0a57TDRna@ralph.baldwin.cx>
User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; )
In-Reply-To: <CANCZdfqzhB41_iizFhooqxU2-z3+aD+tL5hfDWgU-FRb_dV0Kw@mail.gmail.com>
References: <201801081847.w08IlZ7F033684@repo.freebsd.org>
 <CANCZdfqzhB41_iizFhooqxU2-z3+aD+tL5hfDWgU-FRb_dV0Kw@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3
 (mail.baldwin.cx); Tue, 09 Jan 2018 12:43:52 -0500 (EST)
X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx
X-Virus-Status: Clean
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 09 Jan 2018 17:43:53 -0000

On Monday, January 08, 2018 12:02:09 PM Warner Losh wrote:
> This should have been a nop... libsa specifically creates 'safe' headers
> for all the standard ones.
> 
> Ah, libsa creates a perfectly fine stdint.h, but not a inttypes.h...

Would you prefer it to use stdint.h and stdio.h rather than stand.h?

> Warner
> 
> On Mon, Jan 8, 2018 at 11:47 AM, John Baldwin <jhb@freebsd.org> wrote:
> 
> > Author: jhb
> > Date: Mon Jan  8 18:47:35 2018
> > New Revision: 327705
> > URL: https://svnweb.freebsd.org/changeset/base/327705
> >
> > Log:
> >   Use <stand.h> instead of <inttypes.h> and <stdio.h> in boot code.
> >
> >   In the freestanding boot compile environment, standard headers are not
> >   available.  Curiously, only building with clang exposed this as compiles
> >   with external GCC still succeeded.
> >
> >   Sponsored by: DARPA / AFRL
> >
> > Modified:
> >   head/stand/mips/beri/common/sdcard.c
> >
> > Modified: head/stand/mips/beri/common/sdcard.c
> > ============================================================
> > ==================
> > --- head/stand/mips/beri/common/sdcard.c        Mon Jan  8 18:46:10 2018
> >       (r327704)
> > +++ head/stand/mips/beri/common/sdcard.c        Mon Jan  8 18:47:35 2018
> >       (r327705)
> > @@ -33,8 +33,7 @@
> >  #include <sys/types.h>
> >  #include <sys/endian.h>
> >
> > -#include <inttypes.h>
> > -#include <stdio.h>
> > +#include <stand.h>
> >
> >
> >  /*
> >
> >


-- 
John Baldwin