From owner-svn-ports-all@FreeBSD.ORG Fri Aug 1 06:41:17 2014 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id EFA8E931; Fri, 1 Aug 2014 06:41:16 +0000 (UTC) Received: from shepard.synsport.net (mail.synsport.com [208.69.230.148]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BEC232F85; Fri, 1 Aug 2014 06:41:16 +0000 (UTC) Received: from [192.168.0.21] (unknown [130.255.19.191]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by shepard.synsport.net (Postfix) with ESMTP id 5141643552; Fri, 1 Aug 2014 01:40:53 -0500 (CDT) Message-ID: <53DB3665.6020201@marino.st> Date: Fri, 01 Aug 2014 08:40:37 +0200 From: John Marino Reply-To: marino@freebsd.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 MIME-Version: 1.0 To: Alexey Dokuchaev , marino@freebsd.org Subject: Re: svn commit: r363361 - in head/editors/fte: . files References: <6270029E710D3C52B60B6224@atuin.in.mat.cc> <20140730081413.GA29876@FreeBSD.org> <20140730160843.GA2688@FreeBSD.org> <53D919BC.6010307@marino.st> <20140801051652.GA59625@FreeBSD.org> <20140801060506.GA71116@FreeBSD.org> <53DB3021.7010909@marino.st> <20140801062047.GC71116@FreeBSD.org> <53DB32E8.7020700@marino.st> <20140801063243.GE71116@FreeBSD.org> In-Reply-To: <20140801063243.GE71116@FreeBSD.org> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 01 Aug 2014 12:11:09 +0000 Cc: "svn-ports-head@freebsd.org" , Max Brazhnikov , Antoine Brodin , "svn-ports-all@freebsd.org" , William Grzybowski , "ports-committers@freebsd.org" , Mathieu Arnold , Adam Weinberger X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Aug 2014 06:41:17 -0000 On 8/1/2014 08:32, Alexey Dokuchaev wrote: > On Fri, Aug 01, 2014 at 08:25:44AM +0200, John Marino wrote: >> On 8/1/2014 08:20, Alexey Dokuchaev wrote: >>> Basically right now one patch will overwrite another conflicting one, which >>> ever comes first. I think I can add a check beforea > $${OUT} and issue an >>> error and refuse to overwrite a file, or maybe just warn. Which you prefer? >> >> Neither. I prefer the original character escaped with itself You may >> not like this, but something like: [...] > > You're right, I don't. :-) However, I will implement autoexpantion (char > -> charchar) since it doesn't add too much complexity. > >> Thoughts? any potential of overwritting is bad. > > Well, my original idea (bail out with an error) is how I saw we prevent > overwriting: by asserting that output file does not exist; you think it is > not robust enough? No, because you don't cover the case where both files legitimately need patching. Why bail out with error when I *want* both patches to exist? You are forcing me to rename one? to what? I've been using "_" => "__" for a while now, it's not bad. Yes, double underscore remains but a very low frequency. The main issue is that it represents a different character ("_") than it does now ("\"). John