From owner-svn-src-all@freebsd.org Mon Oct 12 12:39:48 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B757AA11AAD; Mon, 12 Oct 2015 12:39:48 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x235.google.com (mail-wi0-x235.google.com [IPv6:2a00:1450:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 437FA18B2; Mon, 12 Oct 2015 12:39:48 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wicgb1 with SMTP id gb1so147363248wic.1; Mon, 12 Oct 2015 05:39:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=CtOGobR8yu8XwqMzcOiSsLn0aCIfOrHxkaUt3iKxotI=; b=LIij0eG3NYw5uBOzBREiKSaris8cPhEev97952qpzk/1/4+yb2QNnZLpC+wwcUEuI0 QZ33oH/27FJvsGemYhYib38+QzhmvmHuur51cEO8ZH2IsnzQ0D5WCrCzmNgbeJgT8oBf vguqx8ZzubKH0yvCLiH3NwQPJxP5IqoNekf2upMzdlQtIwPgHQigk1hSN9WvLUQ1nhq2 hoTi3YmEJKuBuD7MjkkkMTzZmjcN9haNYguFkVsBBwzplVqlw3l+Aa2+m7etHWrK+Pf5 Rh0bfJSLw7oYQ/VYPrH/4ZmQIAVKx7bLMT7+0JtaUm/rMjLwKJ+Ss6Oj9ilBSMzLG+Rp R9NQ== X-Received: by 10.194.171.69 with SMTP id as5mr30231828wjc.137.1444653586716; Mon, 12 Oct 2015 05:39:46 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id i3sm10744010wij.9.2015.10.12.05.39.46 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Oct 2015 05:39:46 -0700 (PDT) Sender: Baptiste Daroussin Date: Mon, 12 Oct 2015 14:39:44 +0200 From: Baptiste Daroussin To: Peter Wemm Cc: svn-src-head@freebsd.org, Adrian Chadd , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r289087 - in head: etc etc/dma libexec libexec/dma libexec/dma-mbox-create libexec/dma/dma libexec/dma/dma-mbox-create share/examples share/examples/dma Message-ID: <20151012123944.GA55137@ivaldir.etoilebsd.net> References: <201510092209.t99M9iPx025401@repo.freebsd.org> <20151010144422.GN91729@ivaldir.etoilebsd.net> <18764496.s6PQvKbF0B@overcee.wemm.org> <20151012120239.GT91729@ivaldir.etoilebsd.net> <20151012122452.GU91729@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XsQoSWH+UP9D9v3l" Content-Disposition: inline In-Reply-To: <20151012122452.GU91729@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Oct 2015 12:39:48 -0000 --XsQoSWH+UP9D9v3l Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 12, 2015 at 02:24:52PM +0200, Baptiste Daroussin wrote: > On Mon, Oct 12, 2015 at 02:02:39PM +0200, Baptiste Daroussin wrote: > > On Mon, Oct 12, 2015 at 03:28:58AM -0700, Peter Wemm wrote: > > > On Saturday, October 10, 2015 04:44:23 PM Baptiste Daroussin wrote: > > > > On Fri, Oct 09, 2015 at 08:15:57PM -0700, Adrian Chadd wrote: > > > > > I think this broke being able to do installworld as non-root > > > > >=20 > > > > > 21:03 <@adrian> =3D=3D=3D> libexec/dma/dmagent (installconfig) > > > > > 21:03 <@adrian> install: > > > > > /home/adrian/work/freebsd/head-embedded/src/../root/mips_ap/etc/d= ma/dma.co > > > > > nf: chown/chgrp: Operation not permitted > > > > > 21:03 <@adrian> *** Error code 71 > > > >=20 > > > > Fixed in r289115 > > > >=20 > > > > Bapt > > >=20 > > > You've broken etcupdate with this, and also the freebsd cluster. > > >=20 > > > # etcupdate status > > > Warnings: > > > Non-empty directory remains: /etc/dma > > >=20 > > > You also made it delete ppp.conf: > > > D /etc/ppp/ppp.conf > > > D /etc/ppp > > >=20 > > > Deleting people's config files is not good. > >=20 > > Hu, make installconfig is hooked to make distribution, etcupdate is cal= ling make > > distribution to retrive the list of configurations files so it should g= et the > > config for ppp. > >=20 > > Let me look into the etcupdate to see what is wrong with it. > >=20 > > Best regards, > > Bapt >=20 >=20 >=20 > After checking I can confirm that etcupdate properly get the config: >=20 > etcupdate build something.tar > tar tvf something.tar | grep ppp.conf > -rw------- 0 root wheel 1144 Oct 12 14:23 ./etc/ppp/ppp.conf >=20 >=20 > Am I missing something? I compared the tarball from before and after my change and there is no differences. I Compared: r289000 and r289183 Bapt --XsQoSWH+UP9D9v3l Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlYbqhAACgkQ8kTtMUmk6ExlSgCfSop+6xqEczs8A6j/8gFsfOAQ zD8AnRmFJ8s2zOdzTHYZHHFWYxY71TON =6Wb7 -----END PGP SIGNATURE----- --XsQoSWH+UP9D9v3l--