From owner-freebsd-current Wed Nov 13 10: 7:29 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AC2A837B401 for ; Wed, 13 Nov 2002 10:07:26 -0800 (PST) Received: from rootlabs.com (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id 0F42643E7B for ; Wed, 13 Nov 2002 10:07:22 -0800 (PST) (envelope-from nate@rootlabs.com) Received: (qmail 40017 invoked by uid 1000); 13 Nov 2002 18:07:22 -0000 Date: Wed, 13 Nov 2002 10:07:22 -0800 (PST) From: Nate Lawson To: Sheldon Hearn Cc: current@freebsd.org Subject: Re: sleep(1) behavior In-Reply-To: <20021113080425.GO1278@starjuice.net> Message-ID: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-2102765526-1037210842=:39871" Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-2102765526-1037210842=:39871 Content-Type: TEXT/PLAIN; charset=US-ASCII On Wed, 13 Nov 2002, Sheldon Hearn wrote: > On (2002/11/12 16:37), Nate Lawson wrote: > > > I've found an interesting contradiction and was wondering what behavior > > sleep should have. It checks for a command line flag with getopt(3) and > > exits with usage() if it finds one. However, it then checks for a '-' or > > '+' sign. If negative, it behaves like "sleep 0" and exits > > immediately. This case can almost never be triggered since the > > getopt(3) will catch the minus sign, even if a digit follows it. > > > > Current behavior: > > sleep 0 = exits immediately > > sleep -1 = exits with usage() > > sleep -f = exits with usage() > > sleep " -1" = exits immediately and is the only way I know to trigger > > the negative case. > > > > What is the standard, desired behavior? > > IEEE Std 1003.2-1992 says: > > time A nonnegative decimal integer specifying the number of > seconds for which to suspend execution. > > I think it's pretty clear that negative time arguments to sleep(1) are > not portable. Thanks, that's what I was expecting. The attached patch provides the following behavior: sleep 0 = exit 0 immediately sleep [ \t]*1AAAA = sleep 1 second sleep [ \t]*\.2zzz = sleep .2 seconds sleep [ \t]*-.* = usage() Please let me know if there are any problems with this patch. -Nate --0-2102765526-1037210842=:39871 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="sleep.diff" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="sleep.diff" SW5kZXg6IHNsZWVwLmMNCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NClJDUyBm aWxlOiAvaG9tZS9uY3ZzL3NyYy9iaW4vc2xlZXAvc2xlZXAuYyx2DQpyZXRy aWV2aW5nIHJldmlzaW9uIDEuMTINCmRpZmYgLXUgLXIxLjEyIHNsZWVwLmMN Ci0tLSBzbGVlcC5jCTMwIEp1biAyMDAyIDA1OjE1OjA0IC0wMDAwCTEuMTIN CisrKyBzbGVlcC5jCTEzIE5vdiAyMDAyIDE4OjAwOjMxIC0wMDAwDQpAQCAt NDcsMTAgKzQ3LDEwIEBADQogDQogI2luY2x1ZGUgPGN0eXBlLmg+DQogI2lu Y2x1ZGUgPGxpbWl0cy5oPg0KLSNpbmNsdWRlIDxzdGRpby5oPg0KICNpbmNs dWRlIDxzdGRsaWIuaD4NCiAjaW5jbHVkZSA8dGltZS5oPg0KICNpbmNsdWRl IDx1bmlzdGQuaD4NCisjaW5jbHVkZSA8c3RyaW5nLmg+DQogDQogdm9pZCB1 c2FnZSh2b2lkKTsNCiANCkBAIC01OSw1MSArNTksNDMgQEANCiB7DQogCXN0 cnVjdCB0aW1lc3BlYyB0aW1lX3RvX3NsZWVwOw0KIAlsb25nIGw7DQotCWlu dCBjaCwgbmVnOw0KIAljaGFyICpwOw0KIA0KLQl3aGlsZSAoKGNoID0gZ2V0 b3B0KGFyZ2MsIGFyZ3YsICIiKSkgIT0gLTEpDQotCQlzd2l0Y2goY2gpIHsN Ci0JCWNhc2UgJz8nOg0KLQkJZGVmYXVsdDoNCi0JCQl1c2FnZSgpOw0KLQkJ CS8qIE5PVFJFQUNIRUQgKi8NCi0JCX0NCi0JYXJnYyAtPSBvcHRpbmQ7DQot CWFyZ3YgKz0gb3B0aW5kOw0KLQ0KLQlpZiAoYXJnYyAhPSAxKSB7DQorCWlm IChhcmdjICE9IDIpIHsNCiAJCXVzYWdlKCk7DQogCQkvKiBOT1RSRUFDSEVE ICovDQogCX0NCiANCi0JcCA9IGFyZ3ZbMF07DQorCXAgPSBhcmd2WzFdOw0K IA0KIAkvKiBTa2lwIG92ZXIgbGVhZGluZyB3aGl0ZXNwYWNlcy4gKi8NCiAJ d2hpbGUgKGlzc3BhY2UoKHVuc2lnbmVkIGNoYXIpKnApKQ0KIAkJKytwOw0K IA0KLQkvKiBDaGVjayBmb3Igb3B0aW9uYWwgYCsnIG9yIGAtJyBzaWduLiAq Lw0KLQluZWcgPSAwOw0KKwkvKiBObyBhcmd1bWVudHMgb3IgbmVnYXRpdmUg dmFsdWVzIGFyZSBhbGxvd2VkICovDQogCWlmICgqcCA9PSAnLScpIHsNCi0J CW5lZyA9IDE7DQotCQkrK3A7DQorCQl1c2FnZSgpOw0KKwkJLyogTk9UUkVB Q0hFRCAqLw0KIAl9DQotCWVsc2UgaWYgKCpwID09ICcrJykNCisNCisJLyog Q2hlY2sgZm9yIG9wdGlvbmFsIGArJyBzaWduLiAqLw0KKwlpZiAoKnAgPT0g JysnKQ0KIAkJKytwOw0KIA0KIAkvKiBDYWxjdWxhdGUgc2Vjb25kcy4gKi8N Ci0JaWYgKGlzZGlnaXQoKHVuc2lnbmVkIGNoYXIpKnApKSB7DQotCQlsID0g c3RydG9sKHAsICZwLCAxMCk7DQotCQlpZiAobCA+IElOVF9NQVgpIHsNCisJ bCA9IDA7DQorCXdoaWxlIChpc2RpZ2l0KCh1bnNpZ25lZCBjaGFyKSpwKSkg ew0KKwkJbCA9IChsICogMTApICsgKCpwIC0gJzAnKTsNCisJCWlmIChsID4g SU5UX01BWCB8fCBsIDwgMCkgew0KIAkJCS8qDQogCQkJICogQXZvaWQgb3Zl cmZsb3cgd2hlbiBgc2Vjb25kcycgaXMgaHVnZS4gIFRoaXMgYXNzdW1lcw0K IAkJCSAqIHRoYXQgdGhlIG1heGltdW0gdmFsdWUgZm9yIGEgdGltZV90IGlz ID49IElOVF9NQVguDQogCQkJICovDQogCQkJbCA9IElOVF9NQVg7DQorCQkJ YnJlYWs7DQogCQl9DQotCX0gZWxzZQ0KLQkJbCA9IDA7DQorCQkrK3A7DQor CX0NCiAJdGltZV90b19zbGVlcC50dl9zZWMgPSAodGltZV90KWw7DQogDQog CS8qIENhbGN1bGF0ZSBuYW5vc2Vjb25kcy4gKi8NCkBAIC0xMTksNyArMTEx LDcgQEANCiAJCX0gd2hpbGUgKGwgLz0gMTApOw0KIAl9DQogDQotCWlmICgh bmVnICYmICh0aW1lX3RvX3NsZWVwLnR2X3NlYyA+IDAgfHwgdGltZV90b19z bGVlcC50dl9uc2VjID4gMCkpDQorCWlmICh0aW1lX3RvX3NsZWVwLnR2X3Nl YyA+IDAgfHwgdGltZV90b19zbGVlcC50dl9uc2VjID4gMCkNCiAJCSh2b2lk KW5hbm9zbGVlcCgmdGltZV90b19zbGVlcCwgKHN0cnVjdCB0aW1lc3BlYyAq KU5VTEwpOw0KIA0KIAlleGl0KDApOw0KQEAgLTEyOCw3ICsxMjAsOCBAQA0K IHZvaWQNCiB1c2FnZSh2b2lkKQ0KIHsNCisJY29uc3QgY2hhciAqbXNnID0g InVzYWdlOiBzbGVlcCBzZWNvbmRzXG4iOw0KIA0KLQkodm9pZClmcHJpbnRm KHN0ZGVyciwgInVzYWdlOiBzbGVlcCBzZWNvbmRzXG4iKTsNCisJd3JpdGUo U1RET1VUX0ZJTEVOTywgbXNnLCBzdHJsZW4obXNnKSk7DQogCWV4aXQoMSk7 DQogfQ0K --0-2102765526-1037210842=:39871-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message