From owner-freebsd-hackers@FreeBSD.ORG Wed Aug 14 08:33:38 2013 Return-Path: Delivered-To: hackers@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id EA03889C; Wed, 14 Aug 2013 08:33:38 +0000 (UTC) (envelope-from prvs=19381d5a45=killing@multiplay.co.uk) Received: from mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 3F3982747; Wed, 14 Aug 2013 08:33:38 +0000 (UTC) Received: from r2d2 ([82.69.141.170]) by mail1.multiplay.co.uk (mail1.multiplay.co.uk [85.236.96.23]) (MDaemon PRO v10.0.4) with ESMTP id md50005488548.msg; Wed, 14 Aug 2013 09:33:29 +0100 X-Spam-Processed: mail1.multiplay.co.uk, Wed, 14 Aug 2013 09:33:29 +0100 (not processed: message from valid local sender) X-MDDKIM-Result: neutral (mail1.multiplay.co.uk) X-MDRemoteIP: 82.69.141.170 X-Return-Path: prvs=19381d5a45=killing@multiplay.co.uk X-Envelope-From: killing@multiplay.co.uk Message-ID: From: "Steven Hartland" To: , "Richard Yao" References: <1376223145-81081-1-git-send-email-ryao@gentoo.org> <8E8C51CCA3474B7A9E2C477D4BCEBB04@multiplay.co.uk> <5207E00F.4000400@gentoo.org> <520B03A7.30406@delphij.net> Subject: Re: [PATCH] Add 4K QUIRK for Intel X25-M, MARVELL SD88SA02 and OCZ Agility 2 Date: Wed, 14 Aug 2013 09:33:37 +0100 MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="iso-8859-1"; reply-type=original Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 6.00.2900.5931 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Cc: hackers@FreeBSD.org, Eitan Adler X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Aug 2013 08:33:39 -0000 ----- Original Message ----- From: "Xin Li" > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 8/11/13 12:03 PM, Richard Yao wrote: >> Is there any possibility that these quirks could be added to the >> upcoming 9.2 release? > > I think so but we need to act fast. > >> Pools composed of affected disks will suffer from performance >> issues until they are reformatted with the correct block size. In >> addition, a certain benchmarking site, whose benchmarks are often >> fodder for trolls, uses the Intel X25-M in its benchmarks. Adding >> the quirk to 9.2 would eliminate an unfair handicap on FreeBSD from >> their next set of benchmarks. > > Actually I'm not 100% sure here: the current FreeBSD ZFS code does not > handle stripesize at all, and thus if you create a pool with the > patch, they will still be ashift=9. Justin (gibbs@) have a patchset > to address this by the way, but since it's not yet in HEAD I wouldn't > expect it be incorporated in 9.2... Indeed, there is nothing which really makes proper use of QUIRKS that I'm aware of and ZFS definitely doesn't. There's a number of patches around which correct that, I've one here too, but none as yet are a total solution to the ashift issue. Regards Steve ================================================ This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it. In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337 or return the E.mail to postmaster@multiplay.co.uk.