From owner-freebsd-current@FreeBSD.ORG Mon Jun 7 21:57:33 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AD3A616A4CE; Mon, 7 Jun 2004 21:57:33 +0000 (GMT) Received: from rwcrmhc13.comcast.net (rwcrmhc13.comcast.net [204.127.198.39]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9900B43D31; Mon, 7 Jun 2004 21:57:33 +0000 (GMT) (envelope-from julian@elischer.org) Received: from interjet.elischer.org ([24.7.73.28]) by comcast.net (rwcrmhc13) with ESMTP id <2004060721572901500mn9r8e>; Mon, 7 Jun 2004 21:57:31 +0000 Received: from localhost (localhost.elischer.org [127.0.0.1]) by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id OAA30085; Mon, 7 Jun 2004 14:57:30 -0700 (PDT) Date: Mon, 7 Jun 2004 14:57:29 -0700 (PDT) From: Julian Elischer To: Gleb Smirnoff In-Reply-To: <20040607214627.GA24142@cell.sick.ru> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Brian Feldman cc: Peter Ulrich Kruppa cc: FreeBSD current users cc: Bosko Milekic cc: net@FreeBSD.org Subject: Re: check for M_DONTWAIT in NG_MKMESSAGE X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jun 2004 21:57:33 -0000 On Tue, 8 Jun 2004, Gleb Smirnoff wrote: > On Mon, Jun 07, 2004 at 04:58:27PM -0400, Brian Feldman wrote: > B> > Seems like you problem is caused (indirectly) by mbuma import. See > B> > > B> > http://lists.freebsd.org/pipermail/freebsd-current/2004-June/028153.html > B> > > B> > Perhaps Bosko has more comments. > B> > B> Please try removing both KASSERT() calls from NG_MKMESSAGE() in > B> src/sys/sys/ng_message.h, and then rebuild (and unload and reload) > B> all netgraph modules. The KASSERT() lines appear to be entirely > B> bogus now. > > Agreed. After mbuma import the first KASSERT() definitely must be removed. > Julian, take a look at this. It must be fixed ASAP. Messages never were done by mbuf so it's a bit puzzling what mbuma has to do with it.. however, removing the KASSERT seems appropriate. > > -- > Totus tuus, Glebius. > GLEBIUS-RIPN GLEB-RIPE >