From owner-svn-src-all@freebsd.org Sun Jun 26 18:52:19 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D66FCB81A69; Sun, 26 Jun 2016 18:52:19 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: from mail-oi0-x232.google.com (mail-oi0-x232.google.com [IPv6:2607:f8b0:4003:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 9B7962819; Sun, 26 Jun 2016 18:52:19 +0000 (UTC) (envelope-from bjkfbsd@gmail.com) Received: by mail-oi0-x232.google.com with SMTP id f189so175915298oig.3; Sun, 26 Jun 2016 11:52:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=GjYdoo1ReWzbKmF6F5sJf4dgYIGagw/fkXSPA441vfc=; b=uAP/zN0LV+g1JhWctymmfTRFT7YhZcwC7wMnzYdHufDVNRz6C95r9BzGd1MF3sskP8 cf5BBPcDHjTOn9/SLHfI9IUrttYgN6IGLZErDMZWuJD3SwoxlY8HAKBDrP91YFAeU58m bFgBfJQi6zQ4JCsQrO5UnPfrYOqKWiEL11UxYAqN7JYaaWi+2sDNqBKUTVoc4Ai6XRuB 18RFRvQvDsJH2UjXDXmeXUxkx3xTT7AGwcB+RDMnJkndkKxsKRU0Dxk5wU5W87WmLg6F DnzZ62HZBepHDnsIe5/OeRlkE2WOtPyECtVq9BTKSW+Bb3OxXS/IE3Xb/7hRBB0EWD5E +TBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=GjYdoo1ReWzbKmF6F5sJf4dgYIGagw/fkXSPA441vfc=; b=ByeBuarHVI0ssZXEX+HPdZnEPPF9Ojs9UKCxlFbBHiBtnMTwQGqSGXfSuuaJQbAh+p 0xGOKsLgvdDAqz+NV+BSGCME01QreOQd+vrXvurgjOntkjkks9cKxnjhJGi3225SfKos w+9qaVv9EAtm5e2zsYa/Rxdnfa773LeEbYj13o8IQnPYi9FdTTwuv5HDYvqqimOZSRp2 063PJRoQL2Adt/XzKBHz+v9b2ctbHaudfXzm3sF8iSNgO2eedfTeXR70Rl+8s6nKsydB d2eW3Io/UUwm5W7O8QNamu+6hoatAjFKA5iIeH+oOS+aMMyNqMZYcl52OOFob9wyGIBt OWDw== X-Gm-Message-State: ALyK8tLmbTw8PQbZUg//q5kdCQxeaS7Xnm67B6JjUxpKQkcL5OaIcPhx9wOyIb1zhBTvMxvIY0F0yYo8l9Yemw== X-Received: by 10.157.44.145 with SMTP id p17mr8501746otb.184.1466967138906; Sun, 26 Jun 2016 11:52:18 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.12.37 with HTTP; Sun, 26 Jun 2016 11:52:18 -0700 (PDT) In-Reply-To: References: <201604241053.u3OAr0bn072180@repo.freebsd.org> From: Benjamin Kaduk Date: Sun, 26 Jun 2016 13:52:18 -0500 Message-ID: Subject: Re: svn commit: r298537 - head/etc/rc.d To: Jens Schweikhardt Cc: "svn-src-head@freebsd.org" , Jan Beich , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 26 Jun 2016 18:52:19 -0000 On Sun, Apr 24, 2016 at 12:01 PM, Jan Beich wrote: > Jens Schweikhardt writes: > > > - parenthesize the "case" string for symmetry and improved > > search for matching paren (e.g. with vi's %) > [...] > > case "${state}" in > > - [oO][nN]) > > + ([oO][nN]) > > swapon /dev/zvol/${name} > > ;; > > For style consistency is more important. Why this case is special unlike > the rest of rc.d/* or rc.subr ? > Coming in quite late, I agree. I think this part should be reverted. -Ben