From owner-freebsd-hackers@FreeBSD.ORG  Fri Mar  4 09:16:17 2005
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4C15316A4D0; Fri,  4 Mar 2005 09:16:17 +0000 (GMT)
Received: from bloodwood.hunterlink.net.au (smtp-local.hunterlink.net.au
	[203.12.144.17])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id EBCB943D1F; Fri,  4 Mar 2005 09:16:15 +0000 (GMT)
	(envelope-from boris@brooknet.com.au)
Received: from ppp2D01.dyn.pacific.net.au (ppp2D01.dyn.pacific.net.au
	[61.8.45.1])j249GAnW005063;	Fri, 4 Mar 2005 20:16:12 +1100
From: Sam Lawrance <boris@brooknet.com.au>
To: Scott Long <scottl@samsco.org>
In-Reply-To: <42271FF6.9040103@samsco.org>
References: <20050302212102.GK11079@elvis.mu.org>
	 <42271FF6.9040103@samsco.org>
Content-Type: text/plain
Date: Fri, 04 Mar 2005 20:17:25 +1100
Message-Id: <1109927845.3361.5.camel@dirk.no.domain>
Mime-Version: 1.0
X-Mailer: Evolution 2.0.1FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
cc: hackers@freebsd.org
cc: Alfred Perlstein <alfred@freebsd.org>
Subject: Re: truss bug + PATCH, pls review
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Mar 2005 09:16:17 -0000

On Thu, 2005-03-03 at 07:32 -0700, Scott Long wrote:
> Alfred Perlstein wrote:
> > Can someone review this?  I think 'u' is incorrectly
> > added to instead of assigned to.  This causes the initial
> > calculation to be garage based and screws up displaying
> > poll information.
> > 
> > I'd like this to be MFC'd before 5.4 if possible.
> > 
> > Index: syscalls.c
> > ===================================================================
> > RCS file: /home/ncvs/src/usr.bin/truss/syscalls.c,v
> > retrieving revision 1.45
> > diff -u -r1.45 syscalls.c
> > --- syscalls.c	5 Sep 2004 05:27:30 -0000	1.45
> > +++ syscalls.c	2 Mar 2005 21:19:13 -0000
> > @@ -414,7 +414,7 @@
> >  	(POLLIN | POLLPRI | POLLOUT | POLLERR | POLLHUP | POLLNVAL | \
> >  	 POLLRDNORM |POLLRDBAND | POLLWRBAND | POLLINIGNEOF) 
> >  
> > -	  u += snprintf(tmp + used, per_fd,
> > +	  u = snprintf(tmp + used, per_fd,
> >  	    "%s%d 0x%hx%s%s%s%s%s%s%s%s%s ",
> >  	    i > 0 ? " " : "",
> >  	    pfd[i].fd,
> > 

While you're on the subject of Trussburger, perhaps someone can comment
on this Problem Report Meal. A McPatch is included.

http://www.freebsd.org/cgi/query-pr.cgi?pr=71749

PS. It really is a McPatch.