From owner-svn-src-user@FreeBSD.ORG  Mon Mar 11 19:25:58 2013
Return-Path: <owner-svn-src-user@FreeBSD.ORG>
Delivered-To: svn-src-user@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id F0924130;
 Mon, 11 Mar 2013 19:25:58 +0000 (UTC)
 (envelope-from asmrookie@gmail.com)
Received: from mail-ie0-x231.google.com (mail-ie0-x231.google.com
 [IPv6:2607:f8b0:4001:c03::231])
 by mx1.freebsd.org (Postfix) with ESMTP id BD98CA92;
 Mon, 11 Mar 2013 19:25:58 +0000 (UTC)
Received: by mail-ie0-f177.google.com with SMTP id 16so5280886iea.22
 for <multiple recipients>; Mon, 11 Mar 2013 12:25:58 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:reply-to:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=4fncV6Xw0pwNJmOCHCQnEh7pYPpW2lxKH6pPJLzzXrw=;
 b=MYMW0OAbHsR9Lf35Ew9M9Qrens/lD6ZqcIDI0EwIN3B2+WfVK3wLrBP9BH1lL6ebVz
 3H5Oo35K9JrW8vQOkTt0LS5HWJwBMX5uHU5LOglITXJB9UWTDc94yuyzuGY2uYNEaUCf
 vigknz/jHraAsrykZk+sgJMvJ+sOUdO8lAQOppcXLQvNXmVeim0OKoUFCdM0IcrS/6NA
 WJAlI6EtPu0f1lx/ntGejSFgbTUUN1QyZiZZa21f/ifP/0jDMQx8HzjrvgTC+N4VYL2t
 dP8aBictJlueVIt00K59dk2rX86OkpeEqNypFti/vDEO6o4Db0jtidhPqxxb0KGsUw7c
 FQNw==
MIME-Version: 1.0
X-Received: by 10.43.103.195 with SMTP id dj3mr9708355icc.3.1363029958346;
 Mon, 11 Mar 2013 12:25:58 -0700 (PDT)
Sender: asmrookie@gmail.com
Received: by 10.42.117.134 with HTTP; Mon, 11 Mar 2013 12:25:58 -0700 (PDT)
In-Reply-To: <513E0EF4.4050304@rice.edu>
References: <201303111350.r2BDoeRI054744@svn.freebsd.org>
 <513E0EF4.4050304@rice.edu>
Date: Mon, 11 Mar 2013 20:25:58 +0100
X-Google-Sender-Auth: nXkW0M0bUJLaCUDrjdvvjIWyRKU
Message-ID: <CAJ-FndC44zQZnGrznPk3_JqSOJnN7kyuk2wXHgr2djsm5ePuLA@mail.gmail.com>
Subject: Re: svn commit: r248162 - user/attilio/vmobj-readlock/sys/vm
From: Attilio Rao <attilio@freebsd.org>
To: Alan Cox <alc@rice.edu>
Content-Type: text/plain; charset=UTF-8
Cc: src-committers@freebsd.org, svn-src-user@freebsd.org
X-BeenThere: svn-src-user@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
Reply-To: attilio@FreeBSD.org
List-Id: "SVN commit messages for the experimental &quot; user&quot;
 src tree" <svn-src-user.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-user>
List-Post: <mailto:svn-src-user@freebsd.org>
List-Help: <mailto:svn-src-user-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-user>,
 <mailto:svn-src-user-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Mar 2013 19:25:59 -0000

On Mon, Mar 11, 2013 at 6:05 PM, Alan Cox <alc@rice.edu> wrote:
> On 03/11/2013 08:50, Attilio Rao wrote:
>> Author: attilio
>> Date: Mon Mar 11 13:50:40 2013
>> New Revision: 248162
>> URL: http://svnweb.freebsd.org/changeset/base/248162
>>
>> Log:
>>   The VM_ALLOC_IFCACHED case does not require any object locking as
>>   it will only go through the object page cache and return.
>>   Lookups in the object's page cache are correctly handled by
>>   the vm_page_queue_free_mtx, which will be acquired correctly in this
>>   case.
>>   Relax the locking assertion.
>>
>
> Umm, no.  The page is moving from the cache to the rtree.  Insertion
> into the latter requires the object to be write locked.

Yeah, I figured out while I was having gym training :)
Huge brainfart, I'll revert soon.

Attilio


-- 
Peace can only be achieved by understanding - A. Einstein