From owner-freebsd-current@FreeBSD.ORG  Tue Apr  5 17:39:54 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 78F7116A4D2; Tue,  5 Apr 2005 17:39:54 +0000 (GMT)
Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu
	[128.208.78.105])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 47AA643D5C; Tue,  5 Apr 2005 17:39:54 +0000 (GMT)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: from troutmask.apl.washington.edu (localhost [127.0.0.1])
	j35Hdrfv015866;	Tue, 5 Apr 2005 10:39:53 -0700 (PDT)
	(envelope-from sgk@troutmask.apl.washington.edu)
Received: (from sgk@localhost)j35Hdr0s015864;
	Tue, 5 Apr 2005 10:39:53 -0700 (PDT)	(envelope-from sgk)
Date: Tue, 5 Apr 2005 10:39:53 -0700
From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: freebsd-current@freebsd.org
Message-ID: <20050405173953.GA12307@troutmask.apl.washington.edu>
References: <20050405171923.GA86590@troutmask.apl.washington.edu>
	<20050405172329.GB86590@troutmask.apl.washington.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050405172329.GB86590@troutmask.apl.washington.edu>
User-Agent: Mutt/1.4.2.1i
cc: re@freebsd.org
Subject: Re: rexecd break world
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 05 Apr 2005 17:39:54 -0000

On Tue, Apr 05, 2005 at 10:23:29AM -0700, Steve Kargl wrote:
> On Tue, Apr 05, 2005 at 10:19:23AM -0700, Steve Kargl wrote:
> > ===> libexec/rexecd (all)
> > cc -O -pipe -march=opteron -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wunused-parameter -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls -c /usr/src/libexec/rexecd/rexecd.c
> > /usr/src/libexec/rexecd/rexecd.c: In function `doit':
> > /usr/src/libexec/rexecd/rexecd.c:206: warning: passing arg 4 of `xgetpwnam' from incompatible pointer type
> > *** Error code 1
> > 
> > Stop in /usr/src/libexec/rexecd.
> > *** Error code 1
> > 
> 
> Watch for cut-n-paste problems.
> 
> --- /tmp/rexecd.c       Tue Apr  5 10:21:37 2005
> +++ /usr/src/libexec/rexecd/rexecd.c    Tue Apr  5 10:20:30 2005
> @@ -139,7 +139,7 @@
>         char user[16], pass[16];
>         struct passwd *pwd, pwd_storage;
>         char *pwdbuf;
> -       int pwdbuflen;
> +       size_t pwdbuflen;
>         int fd, r, sd;
>         u_short port;
>         int pv[2], pid, cc, nfds;
> 

This patch works.

I suspect the at the 5.4 branch is now broken with this change.

-- 
Steve