From owner-svn-src-head@FreeBSD.ORG Tue May 12 04:46:02 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 08358178 for ; Tue, 12 May 2015 04:46:02 +0000 (UTC) Received: from mail-wi0-x229.google.com (mail-wi0-x229.google.com [IPv6:2a00:1450:400c:c05::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A30EF1304 for ; Tue, 12 May 2015 04:46:01 +0000 (UTC) Received: by widdi4 with SMTP id di4so134290428wid.0 for ; Mon, 11 May 2015 21:45:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc:content-type; bh=OniOL2k1qEBVs5k0cy3RmZpquHgwkwbLqkxxvEjsTHg=; b=IyIo5kSPA+Aa3pnSQVaBKbxQMMDApQDkjzutBIu3LXVODOzTEPMy8xlJZYb5SDJlb/ mYjEkehMyoILUtbtvX0Kum1/XGBEfwwxZ/BbL0djbbno/gTYQEtTDsVzZGOSjhdHhBpF 0w+UqOI+mpNrUF/yVXKRLx4yCRSA76qrwIifY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=OniOL2k1qEBVs5k0cy3RmZpquHgwkwbLqkxxvEjsTHg=; b=G1sa2sUbdej39UIcaCLgW5wzqpbh9p6K1GDVaSIfqteYzWATFSRQAbs7lFYfRwifRh 6uX23xwsMoPxMY14b/2PJ/7XvQ15hzlIzwMwQdHvk20BqwdSIMzuya7o34/lMXSGeOOG 13iGJXnJ58hIjE+jIkK3mX4YDtJgFo9G4WqqEyiL5kn+Mg7QjStqV3iT1+P0xSkSVhPQ 67LQdzPeA9NYiwfrkgfVf5ZZAE4wpmYculnJrHtkKcN9o64MiZRKfXFUMEKS83RtxiC3 sco3JVjoR/58qrT/q7l03x8sMYVW/oACoW1mDjYYB+def4Uobw3DzAka/ntIvZPGtJfC MtYg== X-Gm-Message-State: ALoCoQls+FuNTCXriO9uviI/Zuh9p26KEF6plW7b2EAVoVdhqu4iKnSiLkRgIljWrsN/YT4ZO4VH X-Received: by 10.194.9.6 with SMTP id v6mr26606368wja.13.1431405959770; Mon, 11 May 2015 21:45:59 -0700 (PDT) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.28.20.75 with HTTP; Mon, 11 May 2015 21:45:29 -0700 (PDT) In-Reply-To: <20150511191850.GC68045@spindle.one-eyed-alien.net> References: <201505082336.t48NaWRS080408@svn.freebsd.org> <20150511191850.GC68045@spindle.one-eyed-alien.net> From: Eitan Adler Date: Mon, 11 May 2015 21:45:29 -0700 X-Google-Sender-Auth: cP62W6VRemmYKnQkJsTYMD4DMgo Message-ID: Subject: Re: svn commit: r282672 - head/etc/rc.d To: Brooks Davis Cc: John Baldwin , Xin LI , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 May 2015 04:46:02 -0000 On 11 May 2015 at 12:18, Brooks Davis wrote: > On Sun, May 10, 2015 at 03:45:48PM -0400, John Baldwin wrote: >> >> > On May 8, 2015, at 19:36, Xin LI wrote: >> > >> > Author: delphij >> > Date: Fri May 8 23:36:31 2015 >> > New Revision: 282672 >> > URL: https://svnweb.freebsd.org/changeset/base/282672 >> > >> > Log: >> > Always convert uuid to lower case. >> > >> > MFC after: 2 weeks >> > >> > Modified: >> > head/etc/rc.d/hostid >> > >> > Modified: head/etc/rc.d/hostid >> > ============================================================================== >> > --- head/etc/rc.d/hostid Fri May 8 23:29:42 2015 (r282671) >> > +++ head/etc/rc.d/hostid Fri May 8 23:36:31 2015 (r282672) >> > @@ -58,7 +58,7 @@ hostid_set() >> > >> > valid_hostid() >> > { >> > - uuid=$1 >> > + uuid=$(echo $1 | tr '[:upper:]' '[:lower:]') >> >> tr is in /usr/bin so this breaks systems with a separate /usr. Perhaps you could use dd with conv=lcase instead? > > Alterntively, a shell function "ltr" exists in rc.subr for this purpose. Why does the hostid need to be lowercase in the first place? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams