Date: Mon, 11 May 2015 21:45:29 -0700 From: Eitan Adler <eadler@freebsd.org> To: Brooks Davis <brooks@freebsd.org> Cc: John Baldwin <jhb@freebsd.org>, Xin LI <delphij@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r282672 - head/etc/rc.d Message-ID: <CAF6rxgmbDBE4dYQ-qDFZzddnppHqTOT=CPLceQqaiszLWdAh-Q@mail.gmail.com> In-Reply-To: <20150511191850.GC68045@spindle.one-eyed-alien.net> References: <201505082336.t48NaWRS080408@svn.freebsd.org> <C072FED2-FBED-4EF9-9D74-11B485594AD7@FreeBSD.org> <20150511191850.GC68045@spindle.one-eyed-alien.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11 May 2015 at 12:18, Brooks Davis <brooks@freebsd.org> wrote: > On Sun, May 10, 2015 at 03:45:48PM -0400, John Baldwin wrote: >> >> > On May 8, 2015, at 19:36, Xin LI <delphij@FreeBSD.org> wrote: >> > >> > Author: delphij >> > Date: Fri May 8 23:36:31 2015 >> > New Revision: 282672 >> > URL: https://svnweb.freebsd.org/changeset/base/282672 >> > >> > Log: >> > Always convert uuid to lower case. >> > >> > MFC after: 2 weeks >> > >> > Modified: >> > head/etc/rc.d/hostid >> > >> > Modified: head/etc/rc.d/hostid >> > ============================================================================== >> > --- head/etc/rc.d/hostid Fri May 8 23:29:42 2015 (r282671) >> > +++ head/etc/rc.d/hostid Fri May 8 23:36:31 2015 (r282672) >> > @@ -58,7 +58,7 @@ hostid_set() >> > >> > valid_hostid() >> > { >> > - uuid=$1 >> > + uuid=$(echo $1 | tr '[:upper:]' '[:lower:]') >> >> tr is in /usr/bin so this breaks systems with a separate /usr. Perhaps you could use dd with conv=lcase instead? > > Alterntively, a shell function "ltr" exists in rc.subr for this purpose. Why does the hostid need to be lowercase in the first place? -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgmbDBE4dYQ-qDFZzddnppHqTOT=CPLceQqaiszLWdAh-Q>