Date: Fri, 21 Jun 2024 15:42:24 +0200 From: Daniel Engberg <daniel.engberg.lists@pyret.net> To: Thierry Thomas <thierry@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 12594e1aee7b - main - math/mathex: new port, C++ library to parse/evaluate mathematical expressions Message-ID: <224470ebe4c1f9da0c394a33cfde261e@mail.infomaniak.com> In-Reply-To: <ZnVvwBGocIxc0K14@graf.pompo.net> References: <202406211115.45LBFt3m025401@gitrepo.freebsd.org> <74dfc79ede606f9424af2b0f564b01f3@mail.infomaniak.com> <ZnVvwBGocIxc0K14@graf.pompo.net>
next in thread | previous in thread | raw e-mail | index | archive | help
--_=_swift_1718977344_af46be7226463506fb82fd1b251121a8_=_ Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2024-06-21T14:19:12.000+02:00, Thierry Thomas <thierry@freebsd.org> wr= ote: >=C2=A0Le=C2=A0ven.=C2=A021=C2=A0juin=C2=A024=C2=A0=C3=A0=C2= =A014:13:00=C2=A0+0200,=C2=A0Daniel=C2=A0Engberg=C2=A0<daniel.engberg.lists= @pyret.net> >=C2=A0 >=C2=A0=C2=A0=C3=A9crivait=C2=A0: >=C2=A0 >>= =C2=A0=C2=A0A=C2=A0bit=C2=A0cleaner=C2=A0and=C2=A0likely=C2=A0sustainable= =C2=A0solution=C2=A0would=C2=A0be=C2=A0to=C2=A0import >>=C2=A0=C2=A0the= >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0CMake=C2=A0build=C2=A0from=C2=A0Fed= ora/Macports=C2=A0which=C2=A0would=C2=A0likely=C2=A0remove=C2=A0all >>= =C2=A0=C2=A0the >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0manual=C2=A0workarou= nds=C2=A0for=C2=A0upstream's=C2=A0Makefile. >>=C2=A0=C2=A0 >>=C2=A0= =C2=A0=C2=A0https://src.fedoraproject.org/rpms/mathex/blob/rawhide/f/CMakeL= ists.txt >>=C2=A0=C2=A0 >>=C2=A0=C2=A0=C2=A0https://github.com/macports= /macports-ports/blob/master/math/mathex/files/CMakeLists.txt >=C2=A0 >= =C2=A0Well,=C2=A0cmake=C2=A0is=C2=A0rather=C2=A0heavy,=C2=A0and=C2=A0it= =C2=A0seems=C2=A0over-engineering=C2=A0to=C2=A0use=C2=A0it >=C2=A0for >= =C2=A0 >=C2=A0such=C2=A0a=C2=A0small=C2=A0library! >=C2=A0 >=C2=A0--= =C2=A0 >=C2=A0 >=C2=A0Th.=C2=A0Thomas. The only consumer (not link= ed?) uses CMake too so I don't see that much of a concern?=20 Here's a= poc with prefix(ed) examples,matching comment (there a typo) and pkg-des= cr (slightly altered). Plist is also fixed when EXAMPLES are disabled = (needs to be patched either way). https://projects.pyret.net/files/f= reebsd-patches/mathex-cmake.patch Best regards, Daniel --_=_swift_1718977344_af46be7226463506fb82fd1b251121a8_=_ Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable <html><body><div>On 2024-06-21T14:19:12.000+02:00, Thierry Thomas <thier= ry@freebsd.org> wrote:<br></div><div class=3D"ik_mail_quote answerConten= tMessage"><blockquote class=3D"ws-ng-quote"><pre style=3D"white-space: norm= al;"><div>Le ven. 21 juin 24 =C3=A0 14:13:00 +0200, Daniel Engberg <<a h= ref=3D"mailto:daniel.engberg.lists@pyret.net" class=3D"defaultMailLink">dan= iel.engberg.lists@pyret.net</a>><br></div><div> =C3=A9crivait :<br>= </div><div><br></div><blockquote class=3D"ws-ng-quote"><div> A bit cleaner= and likely sustainable solution would be to import the<br></div><div> CMak= e build from Fedora/Macports which would likely remove all the<br></div><di= v> manual workarounds for upstream's Makefile.<br></div><div> <br></div><di= v> <a href=3D"https://src.fedoraproject.org/rpms/mathex/blob/rawhide/f/CMak= eLists.txt" class=3D"defaultMailLink" target=3D"_blank" rel=3D"noopener nor= eferrer" data-ik=3D"ik-secure">https://src.fedoraproject.org/rpms/mathex/bl= ob/rawhide/f/CMakeLists.txt</a><br></div><div> <br></div><div> <a href=3D"h= ttps://github.com/macports/macports-ports/blob/master/math/mathex/files/CMa= keLists.txt" class=3D"defaultMailLink" target=3D"_blank" rel=3D"noopener no= referrer" data-ik=3D"ik-secure">https://github.com/macports/macports-ports/= blob/master/math/mathex/files/CMakeLists.txt</a><br></div></blockquote><div= > <br></div><div>Well, cmake is rather heavy, and it seems over-engineering= to use it for<br></div><div>such a small library!<br></div><div>-- <br></d= iv><div>Th. Thomas.<br></div></pre></blockquote></div><div>The only consume= r (not linked?) uses CMake too so I don't see that much of a concern? <br><= /div><div>Here's a poc with prefix(ed) examples,matching comment (there a t= ypo) and pkg-descr (slightly altered).<br></div><div>Plist is also fixed wh= en EXAMPLES are disabled (needs to be patched either way).<br></div><div><b= r></div><div><a href=3D"https://projects.pyret.net/files/freebsd-patches/ma= thex-cmake.patch">https://projects.pyret.net/files/freebsd-patches/mathex-c= make.patch</a><br></div><div><br></div><div>Best regards,<br></div><div>Dan= iel<br></div></body></html> --_=_swift_1718977344_af46be7226463506fb82fd1b251121a8_=_--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?224470ebe4c1f9da0c394a33cfde261e>