From owner-freebsd-arch@FreeBSD.ORG Fri Mar 6 16:21:28 2009 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C025A106566C for ; Fri, 6 Mar 2009 16:21:28 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: from onelab2.iet.unipi.it (onelab2.iet.unipi.it [131.114.9.129]) by mx1.freebsd.org (Postfix) with ESMTP id 7A2A48FC13 for ; Fri, 6 Mar 2009 16:21:28 +0000 (UTC) (envelope-from luigi@onelab2.iet.unipi.it) Received: by onelab2.iet.unipi.it (Postfix, from userid 275) id A211073098; Fri, 6 Mar 2009 17:10:28 +0100 (CET) Date: Fri, 6 Mar 2009 17:10:28 +0100 From: Luigi Rizzo To: Vadim Goncharov Message-ID: <20090306161028.GA12322@onelab2.iet.unipi.it> References: <20090301153010.GA58942@onelab2.iet.unipi.it> <49AAFD92.105@elischer.org> <8EBEEE24-6473-411D-AE3F-C4D1D3897E51@gmail.com> <20090302190157.GA33704@onelab2.iet.unipi.it> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Cc: freebsd-arch@freebsd.org Subject: Re: spliting kernel ipfw source ? (also involves sctp) X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Mar 2009 16:21:29 -0000 On Fri, Mar 06, 2009 at 12:40:47PM +0000, Vadim Goncharov wrote: > Hi Luigi Rizzo! > > On Mon, 2 Mar 2009 20:01:57 +0100; Luigi Rizzo wrote about 'Re: spliting kernel ipfw source ? (also involves sctp)': > > >>>>>Hi, I am planning to split netinet/ip_fw2.c in a number of smaller files > >>>>>to make it more manageable, and while i do this I would also like to > >>>>>move the files related to ipfw2 (namely ip_fw*c) to a better place. Any > >>>>>objection to moving them to sys/netinet/ipfw2 ? Also, I can't help > > [...] > > > To further clarify, my plan is the following: > > > - leave ip_fw.h and ip_dummynet.h in /sys/netinet in case > > userland code is dependent on their location; > > - create /sys/netinet/ipfw/ to hold the kernel .c files related to > > ipfw and possibly dummynet (and also their private headers if any); > > Exactly that and nothing more? I'm currently working on extending ipfw for > Foundation with userland interface will be changed (and I thinking about > introducing modules), what else do you plan to do? Generally speaking, the kernel/userland interface will remain unchanged both at binary and source level, which means no backward incompatible changes in the sockopt numbers and messages, and no changes in the location and userland-visible parts of the headers. In practical terms, ip_fw.h might lose the definition of struct ip_fw_args, or the prototypes for the various kernel functions. The #ifdef _KERNEL part of ip_dummynet.h should also go to some other file. If you want to contact me, on the list or offline, to discuss what you want to do or what kind of 'modules' (kernel or userland ?) are you thinking about, i'd be more than happy to help. cheers luigi