From owner-freebsd-cvsweb@FreeBSD.ORG  Fri Jul 16 15:09:12 2004
Return-Path: <owner-freebsd-cvsweb@FreeBSD.ORG>
Delivered-To: freebsd-cvsweb@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2EF3F16A4CE
	for <freebsd-cvsweb@freebsd.org>;
	Fri, 16 Jul 2004 15:09:12 +0000 (GMT)
Received: from yorktown.nielsenmedia.com (yorktown.nielsenmedia.com
	[206.113.192.17])
	by mx1.FreeBSD.org (Postfix) with ESMTP id B854F43D1D
	for <freebsd-cvsweb@freebsd.org>;
	Fri, 16 Jul 2004 15:09:11 +0000 (GMT)
	(envelope-from Alex.Quezada@nielsenmedia.com)
Received: from NMRFLIMG1.nmrlan.net (nmrflimg1.nmrlan.net [10.38.67.53])
	i6GF7prE022945	for <freebsd-cvsweb@freebsd.org>;
	Fri, 16 Jul 2004 11:07:51 -0400 (EDT)
Received: from nmrusdunsxg2.nielsenmedia.com (unverified) by
	NMRFLIMG1.nmrlan.net
	<T6ad40ce6650a26433517fc@NMRFLIMG1.nmrlan.net> for
	<freebsd-cvsweb@freebsd.org>; Fri, 16 Jul 2004 11:09:08 -0400
Received: by nmrusdunsxg2.nmrlan.net with Internet Mail Service (5.5.2653.19)
	id <NSB6MB3Q>; Fri, 16 Jul 2004 11:09:44 -0400
Message-ID: <762A181C0D966E459A2EB3B810142C7707B2196B@nmrusdunsx12.nmrlan.net>
From: "Quezada, Alex" <Alex.Quezada@NielsenMedia.com>
To: "'freebsd-cvsweb@freebsd.org'" <freebsd-cvsweb@freebsd.org>
Date: Fri, 16 Jul 2004 11:09:03 -0400
MIME-Version: 1.0
X-Mailer: Internet Mail Service (5.5.2653.19)
Content-Type: text/plain;
	charset="iso-8859-1"
Subject: Bug in sub hrefquote
X-BeenThere: freebsd-cvsweb@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS Web maintenance mailing list <freebsd-cvsweb.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-cvsweb>
List-Post: <mailto:freebsd-cvsweb@freebsd.org>
List-Help: <mailto:freebsd-cvsweb-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-cvsweb>,
	<mailto:freebsd-cvsweb-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Jul 2004 15:09:12 -0000

Hi,

	this routine is incorrectly translating spaces into +:  
y/ /+/;

	This is wrong, and if you have directories in your path that include
spaces, the link you get is wrong.  I have replaced this with a substitution
of '%20', which works as expected.  Here's how it ends up:

sub hrefquote($)
{
  local ($_) = @_;

  s/ /%20/g;

  htmlquote($_);
}

	There's probably other ways to do this (like urlencode), but this
seems simpler.

	Thanks!

		Alex

PS: I figured out my broken binary problem.  BEA Weblogic's cgi interpreter
was the culprit.  I installed Apache, and all is peachy now.