From owner-svn-src-head@FreeBSD.ORG Tue Sep 23 18:21:01 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4268855E; Tue, 23 Sep 2014 18:21:01 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A844230E; Tue, 23 Sep 2014 18:21:00 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.9/8.14.9) with ESMTP id s8NIKpAX011924 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 23 Sep 2014 21:20:52 +0300 (EEST) (envelope-from kostik@tom.home) DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua s8NIKpAX011924 Received: (from kostik@localhost) by tom.home (8.14.9/8.14.9/Submit) id s8NIKpad011923; Tue, 23 Sep 2014 21:20:51 +0300 (EEST) (envelope-from kostik) Date: Tue, 23 Sep 2014 21:20:51 +0300 From: Konstantin Belousov To: Bryan Drewery Subject: Re: svn commit: r272032 - head/sys/conf Message-ID: <20140923182051.GF8870@kib.kiev.ua> References: <201409231704.s8NH4Lcv098184@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201409231704.s8NH4Lcv098184@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Status: No, score=0.2 required=5.0 tests=ALL_TRUSTED, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.0 X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Sep 2014 18:21:01 -0000 On Tue, Sep 23, 2014 at 05:04:21PM +0000, Bryan Drewery wrote: > Author: bdrewery > Date: Tue Sep 23 17:04:21 2014 > New Revision: 272032 > URL: http://svnweb.freebsd.org/changeset/base/272032 > > Log: > DEBUG_LOCKS no longer modifies 'struct vnode', nor does fstat(1) use it. > fstat(1) now uses libprocstat(9). There is no userland impact to using this. DEBUG_VFS_LOCKS does modify KBI of VFS, by adding struct stack to lockmgr, and lockmgr is embedded into each struct vnode. VFS modules, in particular, filesystems, compiled for mismatched kernel WRT DEBUG_VFS_LOCKS, would cause strange breakage. > > MFC after: 3 days > > Modified: > head/sys/conf/NOTES > > Modified: head/sys/conf/NOTES > ============================================================================== > --- head/sys/conf/NOTES Tue Sep 23 16:06:28 2014 (r272031) > +++ head/sys/conf/NOTES Tue Sep 23 17:04:21 2014 (r272032) > @@ -2625,9 +2625,7 @@ options NSFBUFS=1024 > # Enable extra debugging code for locks. This stores the filename and > # line of whatever acquired the lock in the lock itself, and changes a > # number of function calls to pass around the relevant data. This is > -# not at all useful unless you are debugging lock code. Also note > -# that it is likely to break e.g. fstat(1) unless you recompile your > -# userland with -DDEBUG_LOCKS as well. > +# not at all useful unless you are debugging lock code. > # > options DEBUG_LOCKS >