Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Jan 2012 15:08:15 -0800
From:      Doug Barton <dougb@FreeBSD.org>
To:        Gabor Kovesdan <gabor@FreeBSD.org>
Cc:        Michael Scheidell <scheidell@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org, Greg Larkin <glarkin@FreeBSD.org>, raven428@gmail.com, cvs-ports@FreeBSD.org
Subject:   Re: cvs commit: ports/devel/pinba_engine Makefile distinfo ports/devel/pinba_engine/files patch-src__ha_pinba.cc
Message-ID:  <4F0CC4DF.6030906@FreeBSD.org>
In-Reply-To: <4F0C2E7C.6070802@FreeBSD.org>
References:  <201201061944.q06JiwUR048089@repoman.freebsd.org> <4F0BF9F3.40009@FreeBSD.org> <4F0C2E7C.6070802@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 01/10/2012 04:26, Gabor Kovesdan wrote:
> Em 10-01-2012 09:42, Doug Barton escreveu:
>> Can you fix this using WITH_MYSQL_VER= 52 please? The way that you're
>> using MYSQL_PORTDIR isn't going to work. Take a look at
>> ports/Mk/bsd.databases.mk for more information on how to properly
>> specify dependencies for mysql ports.
>>
>> Also, FYI, we no longer have 323 or 40 in the tree.
> I have checked this and actually it seems USE_MYSQL can be limited to
> server and 323 and 40 can be removed as you say. However, the port
> directory trick was not introduced by Michael and afaik the port worked
> before. Or just nobody complained. The problem here is that the build
> requires the MySQL server source and you cannot do that with
> BUILD_DEPENDS, so the usual framework features do not work here.

It was glarkin that introduced the bogus MYSQL_PORTDIR definition
originally. But it was the addition of this:

              ${NONEXISTENT}:${MYSQL_PORTDIR}:configure \

in version 1.3 (by Michael, not in the PR) that is causing my INDEX
build to create errors, since /usr/ports/databases/mysql52-server
doesn't exist.

I'm not sure why portindex hates that line more than it hated the
already bogus line above it, but it does. I'm also not sure how a 3-part
build dep could be valid, but I'm not up to speed on all the latest
tricks there.

The correct fix is probably to remove that line and add something like
(untested):

.if ${MYSQL_VER} == 52
MYSQL_PORTDIR=       ${PORTSDIR}/databases/mariadb-server
.else
MYSQL_PORTDIR=       ${PORTSDIR}/databases/mysql${MYSQL_VER}-server
.endif

That should allow it to work with mariadb.


hth,

Doug

-- 

	You can observe a lot just by watching.	-- Yogi Berra

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4F0CC4DF.6030906>