From owner-freebsd-hackers Wed Nov 6 21:20:37 1996 Return-Path: owner-hackers Received: (from root@localhost) by freefall.freebsd.org (8.7.5/8.7.3) id VAA28644 for hackers-outgoing; Wed, 6 Nov 1996 21:20:37 -0800 (PST) Received: from dg-rtp.dg.com (dg-rtp.rtp.dg.com [128.222.1.2]) by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id VAA28631 for ; Wed, 6 Nov 1996 21:20:34 -0800 (PST) Received: by dg-rtp.dg.com (5.4R3.10/dg-rtp-v02) id AA04721; Thu, 7 Nov 1996 00:20:02 -0500 Received: from lambert.org by dg-rtp.dg.com.rtp.dg.com; Thu, 7 Nov 1996 00:20 EST Received: from dg-rtp.UUCP (uucp@localhost) by ponds.water.net (8.7.5/8.7.3) with UUCP id SAA07220 for freebsd.org!freebsd-hackers; Wed, 6 Nov 1996 18:56:10 -0500 (EST) Received: from reggae.ncren.net by dg-rtp.dg.com (5.4R3.10/dg-rtp-v02) id AA08152; Wed, 6 Nov 1996 13:34:48 -0500 Received: from mcnc.UUCP by reggae.ncren.net (5.65/tas-reggae/may94) id AA18746; Wed, 6 Nov 96 13:34:16 -0500 Received: from ncnoc.ncren.net by reggae.ncren.net (5.65/tas-reggae/may94) id AA18670; Wed, 6 Nov 96 13:27:28 -0500 Received: from stingray.mcnc.org (stingray.mcnc.org [128.109.130.74]) by ncnoc.ncren.net (8.7.4/8.7.3) with ESMTP id NAA24013; Wed, 6 Nov 1996 13:25:18 -0500 (EST) Received: from relay6.UU.NET by stingray.mcnc.org (8.7.5/MCNC/8-10-92) id NAA07841; Wed, 6 Nov 1996 13:23:51 -0500 (EST) for Received: from coyote.Artisoft.COM by relay6.UU.NET with ESMTP (peer crosschecked as: coyote.Artisoft.COM [198.17.250.162]) id QQborp10976; Wed, 6 Nov 1996 13:24:31 -0500 (EST) Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.211]) by coyote.Artisoft.COM (8.7.6/8.7.3) with SMTP id LAA13537; Wed, 6 Nov 1996 11:22:02 -0700 (MST) Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id LAA08484; Wed, 6 Nov 1996 11:14:35 -0700 From: Terry Lambert Message-Id: <199611061814.LAA08484@phaeton.artisoft.com> Subject: Re: More info on the daily panics... To: ponds!ponds!rivers (Thomas David Rivers) Date: Wed, 6 Nov 1996 11:14:34 -0700 (MST) Cc: ponds!lambert.org!terry, ponds!Artisoft.COM!ponds!rivers, ponds!Artisoft.COM!ponds!freebsd.org!dyson, ponds!Artisoft.COM!ponds!freebsd.org!freebsd-hackers, ponds!Artisoft.COM!ponds!lambert.org!terry In-Reply-To: <199611061300.IAA02838@lakes.water.net> from "Thomas David Rivers" at Nov 6, 96 08:00:35 am X-Mailer: ELM [version 2.4 PL24] Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII Sender: owner-hackers@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk > Although this isn't the complete patch you discuss below, > I believe it to be the proper fix for 2.1.5-STABLE.... I'm > providing to a) Let others acquire it, b) Get this into 2.1.6, > c) Ensure I understand the intent of your change. > > This patch doesn't use the nice macro, but it changes getnewvnode() > to allocate a totally new node when we've wrapped around the end of > the list... > > After Terry signs off on this, can someone get it committed to > 2.1.6 (nee 2.1.5-STABLE)... > > - Thanks - > - Dave Rivers - [ ... patch elided ... ] Yes. This is an equivalent workaround. I suppose the big question is: did this fix the problem for you? -- One caution: if you do not use the macro, and the queue type is changed yet again at some later time, this will introduce a "sneaky" bug that will not be obvious. What's worse, if you are already familiar with the code, it will "look right" because it will have been right the last time you looked at it. Remember the queue type change on the mounted fs list? There was a similar bug that "looked right" (I think that's where the macro came from, FWIW). Terry Lambert terry@lambert.org --- Any opinions in this posting are my own and not those of my present or previous employers.