From owner-freebsd-multimedia@FreeBSD.ORG Sat Sep 10 10:24:44 2011 Return-Path: Delivered-To: freebsd-multimedia@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4A60D10656F7; Sat, 10 Sep 2011 10:24:44 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe05.c2i.net [212.247.154.130]) by mx1.freebsd.org (Postfix) with ESMTP id 9F4A88FC17; Sat, 10 Sep 2011 10:24:40 +0000 (UTC) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.1 cv=npWEf5XEtLL8qLh8yAfHNcIa2ktE1/5Qf1/k+5E0ZhU= c=1 sm=1 a=SvYTsOw2Z4kA:10 a=AyQZo1s1oNUA:10 a=WQU8e4WWZSUA:10 a=8nJEP1OIZ-IA:10 a=CL8lFSKtTFcA:10 a=i9M/sDlu2rpZ9XS819oYzg==:17 a=6I5d2MoRAAAA:8 a=KBpVlFAR-d7LEG76LXIA:9 a=Ye0B38K_9MZLi0l6V_4A:7 a=wPNLvfGTeEIA:10 a=i9M/sDlu2rpZ9XS819oYzg==:117 Received: from [188.126.198.129] (account mc467741@c2i.net HELO laptop002.hselasky.homeunix.org) by mailfe05.swip.net (CommuniGate Pro SMTP 5.2.19) with ESMTPA id 175650905; Sat, 10 Sep 2011 12:24:37 +0200 From: Hans Petter Selasky To: freebsd-multimedia@freebsd.org Date: Sat, 10 Sep 2011 12:21:52 +0200 User-Agent: KMail/1.13.5 (FreeBSD/8.2-STABLE; KDE/4.4.5; amd64; ; ) References: <20110908212945.GA22059@darkbeer.org> <4E6B2B42.3040006@FreeBSD.org> In-Reply-To: <4E6B2B42.3040006@FreeBSD.org> X-Face: *nPdTl_}RuAI6^PVpA02T?$%Xa^>@hE0uyUIoiha$pC:9TVgl.Oq, NwSZ4V"|LR.+tj}g5 %V,x^qOs~mnU3]Gn; cQLv&.N>TrxmSFf+p6(30a/{)KUU!s}w\IhQBj}[g}bj0I3^glmC( :AuzV9:.hESm-x4h240C`9=w MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <201109101221.52950.hselasky@c2i.net> Cc: Andriy Gapon Subject: Re: Fwd: Trivial sound fix that should be in 9. X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 10 Sep 2011 10:24:44 -0000 On Saturday 10 September 2011 11:17:54 Andriy Gapon wrote: > Can anyone on this list please review the following PR and patch? > It seems sufficiently trivial, so if nobody reviews or objects to it, I > will try to ask for RE approval of this patch in a couple of days. > > -------- Original Message -------- > > A while back a colleague sent this fix in for OSS4 it's extremely trivial > and should really make it into 9 as more software is being affected. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=156433 > > Since ariff has been idle for a while it was suggested I send an email to > the last person to touch the file. > Hi, Except for the style, the patch looks good. IOCTL arguments are however not bigger than 32-bit, even though unsigned long is used. I think the problem here is sign-extension from int to unsigned long. If the xcmd was unsigned int, that would solve the problem aswell. --HPS