From owner-freebsd-ports-bugs@FreeBSD.ORG Tue May 17 16:00:27 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C36A91065673 for ; Tue, 17 May 2011 16:00:27 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 8880D8FC20 for ; Tue, 17 May 2011 16:00:27 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p4HG0RIt091048 for ; Tue, 17 May 2011 16:00:27 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p4HG0RUB091047; Tue, 17 May 2011 16:00:27 GMT (envelope-from gnats) Resent-Date: Tue, 17 May 2011 16:00:27 GMT Resent-Message-Id: <201105171600.p4HG0RUB091047@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Rachel Flynn Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 645FA106566C for ; Tue, 17 May 2011 15:55:15 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 550D98FC17 for ; Tue, 17 May 2011 15:55:15 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p4HFtF7p089931 for ; Tue, 17 May 2011 15:55:15 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p4HFtE0J089930; Tue, 17 May 2011 15:55:14 GMT (envelope-from nobody) Message-Id: <201105171555.p4HFtE0J089930@red.freebsd.org> Date: Tue, 17 May 2011 15:55:14 GMT From: Rachel Flynn To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/157121: portmaster traverses and modifies dirctory trees it should not X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 May 2011 16:00:27 -0000 >Number: 157121 >Category: ports >Synopsis: portmaster traverses and modifies dirctory trees it should not >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue May 17 16:00:27 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Rachel Flynn >Release: 8.2-STABLE >Organization: >Environment: FreeBSD datakitty.lan 8.2-PRERELEASE FreeBSD 8.2-PRERELEASE #0 r217868: Tue Jan 25 15:22:59 AKST 2011 rach@datakitty.lan:/data/obj/usr/src/sys/GENERIC amd64 >Description: In parent_exit, portmaster deletes all empty directories below $WRKDIRPREFIX. This assumes that anything below $WRKDIRPREFIX is for the ports system, but it is not. A typical case is to use MAKEOBJDIRPREFIX=/usr/obj for src and WRKDIRPREFIX=/usr/obj for ports. portmaster will now traverse /usr/obj/usr/src in parent_exit which a) takes long and b) is not portmaster to modify. >How-To-Repeat: Run portmaster to install a port. >Fix: --- portmaster.orig 2011-05-08 02:20:04.000000000 -0800 +++ portmaster 2011-05-17 07:38:47.000000000 -0800 @@ -143,7 +143,7 @@ for f in ${TMPDIR}/f-${PM_PARENT_PID}-*; do pm_unlink $f ; done [ -n "$PM_WRKDIRPREFIX" ] && - find -d $PM_WRKDIRPREFIX -mindepth 1 -type d -empty -delete 2>/dev/null + find -d $PM_WRKDIRPREFIX$pd -mindepth 1 -type d -empty -delete 2>/dev/null case "$DISPLAY_LIST" in *' '*) if [ -n "$1" ]; then >Release-Note: >Audit-Trail: >Unformatted: