From owner-dev-commits-src-main@freebsd.org Wed Mar 3 00:29:57 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 2716A556CCA for ; Wed, 3 Mar 2021 00:29:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qt1-x830.google.com (mail-qt1-x830.google.com [IPv6:2607:f8b0:4864:20::830]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dqvyr2pHpz3rQr for ; Wed, 3 Mar 2021 00:29:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qt1-x830.google.com with SMTP id o1so11860309qta.13 for ; Tue, 02 Mar 2021 16:29:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7TXoQMBcBCrCo2Y18xbdJAPXVlEgTZ1kXAPzDUshS1c=; b=wZA9gePAScKoc5TpISwRlZY0lfYfXWbPf7+tcykOQVf/2gw/vYLUqKP4ERDBEgMuDq L6/zG1bcVpWz3+rk4NQmyM8sxGYfzVCwqIDMCoEQxPFS/rsXBrQVYQyvee2Nv86kCTNM onaJHvsW4U2xilVdwT4j+JdxFcAbKvG1EXVOK+nhYK3udiOGhHHi5Sa/QGDEMS5VWg0F txSmqUigs1iCBbMexdWtN2JdTTLYjFSW+GhgouL7GhvZsoQhfmejVvxpZRSmIH/mZLqi WsXHv1Bsr5wP3wmKmQH2D7WZkW0vQ5O1LlfAgnMkkKMy91Gsg2QgeNlBVeoLA/7L59Q0 dXZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7TXoQMBcBCrCo2Y18xbdJAPXVlEgTZ1kXAPzDUshS1c=; b=K7Z1CxIIpYQ4PuQRNr8FFV5TtdvwQ6KEe2Tr0gnYkQx1gKns8JJt+z/Iw1lIIOiW6u KJDJSvuezi+EpxETXV9eGVqNf9CaCwYsylLLzmWcC1PDbChez7t3exBhDeLtvb/DYiCW XQFF/Jb6NeVKXmk60Z1udCTkEAVy7dtkWaKDm94lLACdc7Wvw0t4ZamAzdQhRzEhtL6H LDLEXFZDjy9aRtdoSqQ+FNDjNBqXWfHWRM8ek9Tl24nHH/La21BZRmPioSXQG2b9rC/H f4nYebnO0vWK6G8g3vWe+cki72nHFU445C9eYR7q/GbhMCVGiOoEU1NtCB14m0ldDu7q 056Q== X-Gm-Message-State: AOAM533sCY1nRrXms4LwICzt7QDjPYmeWoQ7ARedHLf5CkuWcifgk4xo evCgujwutxTbMK7hs5/hcSlt/SiKEkBhRmXyhNEiug== X-Google-Smtp-Source: ABdhPJzvWZwFj4SGKE1wLod7FUe0qSCP9BorNWV0SC44W7gTPAaIegHxFdPc9OS6L+Rglf6U1LvbCXexf1sO/4Zk+T8= X-Received: by 2002:a05:622a:90:: with SMTP id o16mr19807264qtw.49.1614731395577; Tue, 02 Mar 2021 16:29:55 -0800 (PST) MIME-Version: 1.0 References: <202103021856.122IuYgV048086@gndrsh.dnsmgr.net> <3d947e4c-a529-0b27-a8d7-415600783e53@freebsd.org> In-Reply-To: From: Warner Losh Date: Tue, 2 Mar 2021 17:29:44 -0700 Message-ID: Subject: Re: git: 2c26d77d989a - main - Remove /boot/efi from mtree, missed in 0b7472b3d8d2. To: Nathan Whitehorn Cc: "Rodney W. Grimes" , Brandon Bergren , src-committers , "" , dev-commits-src-main@freebsd.org X-Rspamd-Queue-Id: 4Dqvyr2pHpz3rQr X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=wZA9gePA; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::830) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-3.00 / 15.00]; RCVD_TLS_ALL(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[dev-commits-src-main@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; RCPT_COUNT_FIVE(0.00)[6]; SPAMHAUS_ZRD(0.00)[2607:f8b0:4864:20::830:from:127.0.2.255]; TO_MATCH_ENVRCPT_SOME(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; NEURAL_HAM_SHORT(-1.00)[-1.000]; RCVD_IN_DNSWL_NONE(0.00)[2607:f8b0:4864:20::830:from]; R_SPF_NA(0.00)[no SPF record]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; RBL_DBL_DONT_QUERY_IPS(0.00)[2607:f8b0:4864:20::830:from]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; MAILMAN_DEST(0.00)[dev-commits-src-main]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.34 X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Mar 2021 00:29:57 -0000 On Tue, Mar 2, 2021 at 5:26 PM Warner Losh wrote: > > > On Tue, Mar 2, 2021 at 11:58 AM Nathan Whitehorn > wrote: > >> >> >> On 3/2/21 1:56 PM, Rodney W. Grimes wrote: >> >> >> >> On Tue, Mar 2, 2021, at 12:26 PM, Rodney W. Grimes wrote: >> >>> This fails to apply the proper owner/group and mode values >> >>> using what ever defaults are in place of the process running >> >>> the build. >> >> Keep in mind that this is the root of a mounted filesystem in the case >> where it matters, and the filesystem being mounted there doesn't support >> proper modes anyway, so the mtree values are a bit irrelevant anyway as the >> actual control of that is in the fstab. >> > That assumes the mount is done and/or kept. My concern is more >> > of a lack security (aka world writable) /boot/efi getting created >> > in a distribution that then is *not* mounted for some reason, >> > either by choice or error. >> > >> > mkdir should be stricken from use when possible, install -d >> > should be used instead. >> > >> >> But that can't happen in this code. For one thing, it's only used in a >> controlled environment to generate SD-card images for a handful of ARM >> boards. For another the mount is set up and installed in fstab a couple >> lines further down the same script. >> > > Removing this from mtree.root wasn't what was agreed upon. Please put it > back and fix it another way. > > It needs to be in mtree.root because we need it for x86 automatic updating > code that's coming later. > I should explain that it was there as the result of careful negotiation about a year or so ago. If some architecture shouldn't have it, that architecture should remove it. All mainstream architectures need it, and we've biased towards convenience of the vast majority of our users over catering to less popular architectures. It doesn't have to have the ESP mounted on it, but it does need to be there, be in heir, etc. There has been some talk of moving the mount point to /efi, but I think that went nowhere... Warner