From owner-cvs-all Tue Jan 23 16:34:45 2001 Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id 1309A37B6A3; Tue, 23 Jan 2001 16:34:19 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id f0O0YIR17315; Tue, 23 Jan 2001 16:34:18 -0800 (PST) Date: Tue, 23 Jan 2001 16:34:18 -0800 From: Alfred Perlstein To: John Baldwin Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/isofs/cd9660 cd9660_vfsops.c Message-ID: <20010123163418.N26076@fw.wintelcom.net> References: <200101240026.f0O0QJ513283@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200101240026.f0O0QJ513283@freefall.freebsd.org>; from jhb@FreeBSD.org on Tue, Jan 23, 2001 at 04:26:19PM -0800 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * John Baldwin [010123 16:26] wrote: > jhb 2001/01/23 16:26:19 PST > > Modified files: > sys/isofs/cd9660 cd9660_vfsops.c > Log: > Proc locking to protect p_ucred while we obtain additional references. I really don't think you need the PROC_LOCK for these. You only need the 'uc' variable, and even then it's only to protect against rfork threads playing with setuid which is an inhernent race condition as p_ucred shouldn't be NULL. (afaik). Therefore you only need to grab a "snapshot" of p_ucred which you do in order to make sure that the same thing that you're crhold'ing is the same thing that you're passing to the VOP. Just give it some more thought, because I'm not sure I'm right about this. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message